feat(dunning): Add customerId to invoices graphql resolver #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
approved these changes
Aug 29, 2024
ancorcruz
approved these changes
Aug 30, 2024
rsempe
force-pushed
the
feat-dunning
branch
2 times, most recently
from
41c2499
to
c3650c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When fetching invoices, we can filter by
external_idbut it's not currently possible to filter byid.In the case of deleted customers with the same external id, it will return all the related invoices as well.
We want to be able to only return invoices for the active customer.