Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Fix some warning in specs #2540

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

vincent-pochet
Copy link
Collaborator

This PR fixes the following warning messages when running the specs:

WARNING: An expectation of `:should_sync_invoice?` was set on `nil`. To allow expectations on `nil` and suppress this message, set `RSpec::Mocks.configuration.allow_message_expectations_on_nil` to `true`. To disallow expectations on `nil`, set `RSpec::Mocks.configuration.allow_message_expectations_on_nil` to `false`. Called from /home/runner/work/lago-api/lago-api/spec/services/invoices/finalize_open_credit_service_spec.rb:12:in `block (2 levels) in <top (required)>'.

WARNING: An expectation of `:should_sync_sales_order?` was set on `nil`. To allow expectations on `nil` and suppress this message, set `RSpec::Mocks.configuration.allow_message_expectations_on_nil` to `true`. To disallow expectations on `nil`, set `RSpec::Mocks.configuration.allow_message_expectations_on_nil` to `false`. Called from /home/runner/work/lago-api/lago-api/spec/services/invoices/finalize_open_credit_service_spec.rb:13:in `block (2 levels) in <top (required)>'.

Copy link
Contributor

@nudded nudded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice, happy to get rid of these!

@vincent-pochet vincent-pochet merged commit 4679425 into main Sep 6, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the misc-warning-in-specs branch September 6, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants