-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add customer_type to Customers #2544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunomiguelpinto
changed the title
feat: added the fields and the display_name
feat: Add customer_type to Customers
Sep 6, 2024
ivannovosad
requested changes
Sep 9, 2024
ivannovosad
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We currently only create Lago customers as companies, but there is a need to support both companies and individuals. This change is motivated by scenarios where customers may be a mix of B2B and B2C, and where external integrations require handling both Contacts and Companies.
To address this, we are introducing a new field,
customer_type
, to distinguish whether a customer is a company or an individual. Existing customers will remain unaffected withcustomer_type
set to the defaultnil
.Description
This pr is the first step we added the
lastname
, thefirstanem
and thecustomer_type
to the models