Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customer-type): Update stripe customer name with new fields #2564

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

brunomiguelpinto
Copy link
Contributor

@brunomiguelpinto brunomiguelpinto commented Sep 10, 2024

Context

We currently only create Lago customers as companies, but there is a need to support both companies and individuals. This change is motivated by scenarios where customers may be a mix of B2B and B2C, and where external integrations require handling both Contacts and Companies.

To address this, we are introducing a new field, customer_type, to distinguish whether a customer is a company or an individual. Existing customers will remain unaffected with customer_type set to the default nil.

Description

In this PR we're adding the new fields: lastname, firstname to both create and update stripe payloads when the name on the customer is not defined.

@brunomiguelpinto brunomiguelpinto self-assigned this Sep 10, 2024
@brunomiguelpinto brunomiguelpinto added the Customer Customer management label Sep 10, 2024
@brunomiguelpinto brunomiguelpinto marked this pull request as ready for review September 10, 2024 15:58
@brunomiguelpinto brunomiguelpinto changed the title feat: added name param to stripe feat(customer-type): Update stripe customer name with new fields Sep 10, 2024
@brunomiguelpinto brunomiguelpinto merged commit 2c12078 into main Sep 10, 2024
6 checks passed
@brunomiguelpinto brunomiguelpinto deleted the feat-customer-type-stripe branch September 10, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Customer management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants