fix(integration): Add more auto retries for reuqest limit errors #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
approved these changes
Sep 11, 2024
vincent-pochet
added a commit
that referenced
this pull request
Oct 14, 2024
## Context This PR follows #2570 ## Description It updates the way we check for the presence of the rate error limit code in the payload to avoid parsing the JSON body and be independent from the format of the response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Many dead jobs are raised by integration with an
SSS_REQUEST_LIMIT_EXCEEDEDerror code.Theses jobs should be automatically retried without ending up in the dead queue.
Description
This PR adds the logic to dig in the error message of integration response looking for the error code. When this error code is
SSS_REQUEST_LIMIT_EXCEEDEDit now raises a newRequestLimitErrorand related jobs are now able to reprocess up to 10 times