Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customer-type): Do not add empty firstname and lastname to xero payload #2573

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ivannovosad
Copy link
Contributor

Context

We currently only create Lago customers as companies, but there is a need to support both companies and individuals. This change is motivated by scenarios where customers may be a mix of B2B and B2C, and where external integrations require handling both Contacts and Companies.

To address this, we are introducing a new field, customer_type, to distinguish whether a customer is a company or an individual. Existing customers will remain unaffected with customer_type set to the default nil.

Description

We should not send empty firstnme and lastname to Xero, because in that case a contact (instead of a customer) is created.
If we don't send those empty attributes at all a customer is created which is the expected behaviour.

@ivannovosad ivannovosad merged commit a96dab2 into main Sep 12, 2024
6 checks passed
@ivannovosad ivannovosad deleted the fix-customer-type branch September 12, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants