Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Split graphql definitions into two schemas #2603

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

rsempe
Copy link
Collaborator

@rsempe rsempe commented Sep 19, 2024

The goal of this PR is to propose splitting the graphql definitions into two schemas.

One for the customer portal and one for the authenticated API.

As we'll add several resolvers / mutations for the customer portal, I think it could be better to put some isolation.

This first PR allows to keep the original implementation of the graphQL controller as it is... while introducing the 2 new endpoints.

@rsempe rsempe force-pushed the split-graphql-schemas branch 4 times, most recently from e7db418 to 3dc4b3f Compare September 19, 2024 15:44
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

app/graphql/types/api/mutation_type.rb Show resolved Hide resolved
@rsempe rsempe merged commit fd78551 into main Sep 20, 2024
6 checks passed
@rsempe rsempe deleted the split-graphql-schemas branch September 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants