misc(event): Remove ordering of event queries when not required #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
misc-event-store-order
branch
from
ecd7a1c
to
7abfffc
Compare
vincent-pochet
force-pushed
the
misc-event-store-order
branch
from
7abfffc
to
1657b88
Compare
vincent-pochet
force-pushed
the
misc-event-store-order
branch
from
1657b88
to
27cefbe
Compare
jdenquin
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When running aggregation for billable metrics we are (almost) always ordering events by the
timestampproperty.In most cases this order is not necessary since the end-result will not be dependent of the event order (sum, count, max...) and the order clause might slow down the queries.
Description
This PR updates all events-related aggregation queries to get rid of the order and keep it only when required. This should allow for a small gain in aggregation performances.