fix(payment-provider-code): Fix payment provider code change #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivannovosad
force-pushed
the
fix-payment-provider-code
branch
3 times, most recently
from
2b3e630
to
14885c5
Compare
annvelents
reviewed
Oct 2, 2024
ivannovosad
force-pushed
the
fix-payment-provider-code
branch
from
6fdb6b0
to
9666f9f
Compare
annvelents
approved these changes
Oct 2, 2024
ivannovosad
force-pushed
the
fix-payment-provider-code
branch
from
9666f9f
to
12b1c0a
Compare
ivannovosad
force-pushed
the
fix-payment-provider-code
branch
from
12b1c0a
to
a729caa
Compare
vincent-pochet
approved these changes
Oct 3, 2024
db/migrate/20241001105523_add_deleted_at_to_payment_providers.rb
Outdated
Show resolved
Hide resolved
db/migrate/20241001112117_add_deleted_at_to_payment_provider_customers.rb
Outdated
Show resolved
Hide resolved
…mments, optimize migrations
vincent-pochet
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Payment provider integration code update does not reflect on assigned customers
How to reproduce issue?
Create a payment provider integration (tested with stripe but probably happens with all of them)
Assign it to a customer
Update the integration code in the settings OR delete the integration
Expected behaviour
The payment provider value attached to my customer should wither be updated, if integration's code is updated, or removed if integration's code have been removed.
Description
This PR fixes all payment provider services that handle the code update.
It also adds soft-deleting of:
So there are also 2 new migrations that add
deleted_atcolumn and drop and re-create indices because of that.