Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Refactor more pre-call era services #2653

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

vincent-pochet
Copy link
Collaborator

Context

This PR follows #2641 and #2645 and keeps refactoring some old service to take advantage of the call pattern and to remove the user arguments used in BaseService#initialize.

Description

This PR:

  • Turn the Plans::CreateService#create method into a proper Plans::CreateService#call one
  • Remove the need for the current_user argument in Invites::CreateService and move the arguments for the call method to the initializer
  • Refact Invites::RevokeService to take the invite as an argument instead if the id and current_organization and move the argument for the call method to the initializer
  • Remove the current_user argument for the Invoices::CustomerUsageService

@vincent-pochet vincent-pochet merged commit 49bf8dd into main Oct 3, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the misc-refact-call-2 branch October 3, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants