Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event show action to the API #269

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

prognostikos
Copy link
Contributor

Implements getlago/lago#48
Closes getlago/lago#48

@prognostikos
Copy link
Contributor Author

The specs will probably fail due to the missing setup for active record encryption.

@vincent-pochet
Copy link
Collaborator

vincent-pochet commented Jun 17, 2022

Thanks @prognostikos for this PR!

The specs will probably fail due to the missing setup for active record encryption.

Indeed, the spec suite uses secrets from repository and Lago organization. For security reasons these secrets are not exposed to external pull requests.
Since these values are not really sensitive in test env, we should be able to find a way to run specs without using secrests

@vincent-pochet vincent-pochet self-requested a review June 17, 2022 14:47
@vincent-pochet vincent-pochet added Feature Add a new feature to the app API Related to the public API labels Jun 17, 2022
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks good! 💯

app/controllers/api/v1/events_controller.rb Outdated Show resolved Hide resolved
@vincent-pochet vincent-pochet merged commit 5756094 into getlago:main Jun 17, 2022
@vincent-pochet
Copy link
Collaborator

Thank you very much @prognostikos, it will be part of the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to the public API Feature Add a new feature to the app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: add Event show API endpoint
2 participants