fix(gocarless): Refund metadata can contains 3 keys at max #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
approved these changes
Oct 17, 2024
ivannovosad
approved these changes
Oct 17, 2024
vincent-pochet
force-pushed
the
fix-go-carless-refund
branch
from
7e00942
to
0243593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is a fix for
CreditNotes::Refunds::GocardlessCreateJobfailing withGoCardlessPro::InvalidApiUsageError, One of your parameters was incorrectly typedIn the Gocardless API reference the metadata field is defined like this:
Today, we are sending
lago_customer_id,lago_credit_note_id,lago_invoice_idandreasonwich is more than 3...Description
Since the
lago_customer_idis not used when receiving related webhooks this PR removes it from the metadatas so that we only send 3 keys.