fix(stripe): Handle authentication errors for checkout URL #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
fix-handle-expired-stripe-api-key
branch
from
c49f34d
to
1837e04
Compare
vincent-pochet
changed the title
nudded
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes the handling of
Stripe::AuthenticationErrorinPaymentProviderCustomers::StripeCheckoutUrlJobToday this type of error leads to a dead job without notifications sent to the owner of the Strip account.
Since this type of Stripe error cannot be handled on Lago's side we simply have to send a webhook to the account owner and prevent the job from ending in the dead queue.
Description
This PR reuses the logic that was introduce in the
PaymentProviderCustomers::StripeCreateJoband inner services to notify the owner and only log the error