fix(customer): Fix create/update via API when finalize_zero_amount_invoice is nil #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
approved these changes
Oct 17, 2024
rsempe
reviewed
Oct 17, 2024
rsempe
approved these changes
Oct 17, 2024
vincent-pochet
force-pushed
the
fix-nill-finalize_zero_amount_invoice
branch
from
854f1a0
to
c21dd1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Creation of customer via the REST API is failing if a nil value is provided for the
finalize_zero_amount_invoicefield (when called via the Ruby client for example)The raised error is a
ActiveRecord::NotNullViolationDescription
This PR defaults to the default value (
inherit) when it's the case