feat(DataExport) Parallelize data export by splitting it into parts #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
changed the title
nudded
force-pushed
the
feat-data-export-parts
branch
4 times, most recently
from
b28f23b
to
3bbbc32
Compare
vincent-pochet
approved these changes
Oct 25, 2024
ancorcruz
approved these changes
Oct 28, 2024
Co-authored-by: Ancor Cruz <[email protected]>
nudded
force-pushed
the
feat-data-export-parts
branch
from
13588d5
to
e367389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When exporting lots of invoices, we're bumping into the limits of how fast we can export data.
Description
This PR introduces the concept of
DataExportPart. It's a way for data exports to be split into many parts. These parts can then be handled by a single Sidekiq job. This allows a trivial way to split up the data export.once the parts are done, they will be combined into the final export.