bug(PayInAdvance) - Add dedicated lock_key_arguments for pay in advance jobs #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding the
PreciseTotalAmountCentsto Clickhouse, we now have discrepancies between event json. The one coming from Kafka always has "0.0" set for precise total amount cents while the ruby one has nil.This causes 2 duplicate invoice jobs to be enqueued for the same event. The uniqueness key compared all arguments to the job.
The fix is to limit what is used as lock_key via the
lock_key_argumentsmethod.