Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plan-charges-cascading): Support charge filters cascading #2761

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lovrocolic
Copy link
Collaborator

@lovrocolic lovrocolic commented Oct 31, 2024

Context

Currently when plan is updated, these changes are not cascaded to all the children plans.

Description

This PR supports cascading of charge filters. There are several rules:

  • If main attribute that supports cascading is not true -> cascading is disabled
  • Charge filter properties are cascaded only if the same properties are not already overridden in the child filter
  • We need to ensure that all filters that are specific to the child are not changed in any way
  • Logic shouldn't be affected if plan is changed in the meantime (while cascading is processed on the child)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant