feat: Use date service for invoice bounds #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
added
Subscription
rsempe
approved these changes
Aug 19, 2022
jdenquin
reviewed
Aug 19, 2022
vincent-pochet
force-pushed
the
feature/use-subscription-date-service
branch
from
68f584d
to
956def0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to add the ability to choose to bill users at subscription date anniversary and not only on a calendar basis.
Description
This pull request is the last one for this feature.
It uses the previously introduce
Subscriptions::DatesServiceinto the invoice and fees creation logic in order to make it easier to understand and to allow the usage of theanniversarybilling time.All date management is removed from
Invoices::CreateService,Fees::SubscriptionService,Fees::ChargeServiceandInvoices::CustomerUsageServiceand delegated to theSubscriptions::DatesServiceand its subclassesRelated Task
It should be merged before #365 and #364
How Has This Been Tested?
A huge QA will be performed on a staging branch before merging this branch