Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add error message if external id already exist #1586

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

ansmonjol
Copy link
Collaborator

@ansmonjol ansmonjol commented Jul 3, 2024

When adding a subscription to a customer, you can define manually an external ID for this subscription.

This ID have to be unique, but defining an existing one stops the submission of the form but does not show any error visually.

This PR makes sure we display the error message under the corresponding input, and scrolls the screen if needed.

Fixes ISSUE-361

@ansmonjol ansmonjol added the 🥷 chore This doesn't seem right label Jul 3, 2024
@ansmonjol ansmonjol self-assigned this Jul 3, 2024
@ansmonjol ansmonjol enabled auto-merge (rebase) July 3, 2024 09:17
@ansmonjol ansmonjol merged commit cc72764 into main Jul 3, 2024
5 checks passed
@ansmonjol ansmonjol deleted the sub-ext-id branch July 3, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥷 chore This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants