Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: improve charge model logic #1595

Merged
merged 4 commits into from
Jul 11, 2024
Merged

bug: improve charge model logic #1595

merged 4 commits into from
Jul 11, 2024

Conversation

ansmonjol
Copy link
Collaborator

@ansmonjol ansmonjol commented Jul 9, 2024 •
edited
Loading

Context

We noticed multiple gaps between the FE and BE logic around charge handling in the plan form.

Description

This PR make sure it's now aligned by

  • improving the available charge model list in the combobox
  • updating the disabled rule for pay in advance radio
  • updating the disabled rule for prorated toggle
  • improving the global charge update in a general way
  • and testing the new logic matrice

Fixed ISSUE-371

@ansmonjol ansmonjol self-assigned this Jul 9, 2024
@ansmonjol ansmonjol added the 🐞 bug Something isn't working label Jul 9, 2024
@ansmonjol ansmonjol changed the title Fix charge model bug: improve charge model logic Jul 9, 2024
@ansmonjol ansmonjol force-pushed the fix-charge-model branch 2 times, most recently from 69357c4 to 34068cd Compare July 10, 2024 14:04
@ansmonjol ansmonjol merged commit 5f6716d into main Jul 11, 2024
5 checks passed
@ansmonjol ansmonjol deleted the fix-charge-model branch July 11, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovrocolic lovrocolic lovrocolic approved these changes

Assignees

@ansmonjol ansmonjol

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansmonjol @lovrocolic