Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ProgressiveBilling) - Add usage_thresholds & progressive_billing_credit_amount_cents #261

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

nudded
Copy link
Contributor

@nudded nudded commented Aug 29, 2024

No description provided.

Copy link
Contributor

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I also exposed the applied_usage_threshold relation in the API:
getlago/lago-api#2511

Could you also update this PR to take it into account 🙏 🙂

lago_python_client/models/plan.py Outdated Show resolved Hide resolved
lago_python_client/models/usage_threshold.py Show resolved Hide resolved
@nudded nudded force-pushed the feat-prog-billing-add-attrs branch 2 times, most recently from 8ba4d79 to 2f1e331 Compare August 30, 2024 08:12
@nudded nudded force-pushed the feat-prog-billing-add-attrs branch from b47e178 to 97dffca Compare August 30, 2024 09:20
@nudded nudded force-pushed the feat-prog-billing-add-attrs branch from 1230c16 to 3e1d951 Compare August 30, 2024 13:42
Copy link
Contributor

@ancorcruz ancorcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nudded nudded merged commit 485dd83 into main Aug 30, 2024
7 checks passed
@nudded nudded deleted the feat-prog-billing-add-attrs branch August 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants