Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(invoice): Feat add skip zero invoices #214

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Feat(invoice): Feat add skip zero invoices #214

merged 4 commits into from
Sep 6, 2024

Conversation

brunomiguelpinto
Copy link
Contributor

@brunomiguelpinto brunomiguelpinto commented Sep 4, 2024 •
edited
Loading

Add finalize_zero_amount_invoice to the organization and customer this was added on this pr getlago/lago-api#2462

@brunomiguelpinto brunomiguelpinto self-assigned this Sep 4, 2024
@brunomiguelpinto brunomiguelpinto changed the title feat: add finalize_zero_amount_invoice Feat(invoice): Feat add skip zero invoices Sep 4, 2024
vincent-pochet
vincent-pochet reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@vincent-pochet vincent-pochet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the fixtures response organization.json and customer.json so that it matches the new response from the API? 🙏 🙂

@brunomiguelpinto brunomiguelpinto merged commit df4a580 into main Sep 6, 2024
4 checks passed
@brunomiguelpinto brunomiguelpinto deleted the feat-skip-zero-invoices branch September 6, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet approved these changes

Assignees

@brunomiguelpinto brunomiguelpinto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunomiguelpinto @vincent-pochet