Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 - Add RequestId to responses #3836

Merged
merged 1 commit into from
Aug 28, 2021
Merged

S3 - Add RequestId to responses #3836

merged 1 commit into from
Aug 28, 2021

Conversation

bblommers
Copy link
Collaborator

Fixes #3442

zachchurchill
zachchurchill approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@zachchurchill zachchurchill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bblommers bblommers merged commit 5323863 into getmoto:master Aug 28, 2021
@bblommers bblommers added this to the 2.2.6 milestone Aug 28, 2021
@bblommers bblommers deleted the feature/s3_request_id branch August 28, 2021 07:32
@github-actions
Copy link
Contributor

This is now part of moto >= 2.2.6.dev11

@NathanielRN NathanielRN mentioned this pull request Oct 18, 2021
Merged
3 tasks
sahilshah6196 pushed a commit to EBSCOIS/moto that referenced this pull request Dec 20, 2021
@bblommers
S3 - Add RequestId to responses (getmoto#3836)
228d4b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachchurchill zachchurchill zachchurchill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.6
Development

Successfully merging this pull request may close these issues.

Missing RequestId From mocked S3 service API response
2 participants
@bblommers @zachchurchill