Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Form uploads: Ensure streams are closed properly #7405

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

bblommers
Copy link
Collaborator

No description provided.

@bblommers bblommers added this to the 5.0.3 milestone Feb 28, 2024
@bblommers bblommers added the moto-core PR's that touch the core functionality. This will trigger additional tests. label Feb 28, 2024
@bblommers bblommers closed this Feb 28, 2024
@bblommers bblommers reopened this Feb 28, 2024
@bblommers bblommers added moto-core PR's that touch the core functionality. This will trigger additional tests. and removed moto-core PR's that touch the core functionality. This will trigger additional tests. labels Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (9aef694) to head (318ec52).
Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7405      +/-   ##
==========================================
- Coverage   95.88%   95.77%   -0.11%     
==========================================
  Files         843      843              
  Lines       82578    83068     +490     
==========================================
+ Hits        79178    79561     +383     
- Misses       3400     3507     +107     
Flag Coverage Δ
servertests 32.49% <100.00%> (-0.03%) ⬇️
unittests 95.74% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit ca28bdf into getmoto:master Feb 28, 2024
150 checks passed
@bblommers bblommers deleted the s3/file-upload-close-stream branch February 28, 2024 21:03
Copy link
Contributor

This is now part of moto >= 5.0.3.dev29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moto-core PR's that touch the core functionality. This will trigger additional tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant