Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Adding tests of EventBridge notification ObjectCreated:Copy #7407

Conversation

tsugumi-sys
Copy link
Contributor

  • Adding a test of EventBridge notification for ObjectCreated:Copy.
  • Some helper methods to set up AWS resources and retrieve sent event logs were added for reuse.
  • disable_notification argument were added for put_object method to handle notification.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (9aef694) to head (d02c780).
Report is 60 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7407      +/-   ##
==========================================
- Coverage   95.88%   95.77%   -0.11%     
==========================================
  Files         843      843              
  Lines       82578    83072     +494     
==========================================
+ Hits        79178    79565     +387     
- Misses       3400     3507     +107     
Flag Coverage Δ
servertests 32.50% <100.00%> (-0.03%) ⬇️
unittests 95.74% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again @tsugumi-sys

@bblommers bblommers added this to the 5.0.3 milestone Feb 29, 2024
@bblommers bblommers merged commit c404f08 into getmoto:master Feb 29, 2024
39 checks passed
Copy link
Contributor

This is now part of moto >= 5.0.3.dev33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants