Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Entities Table #716

Merged
merged 13 commits into from
Feb 24, 2023
Merged

new: Entities Table #716

merged 13 commits into from
Feb 24, 2023

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Jan 23, 2023

Getting closer, still more things to refactor.

Screen Shot 2023-02-10 at 12 51 42 PM

Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from a discussion with @matthew-white about ideas for reorganizing and reusing code

src/components/dataset/entity/analyze.vue Outdated Show resolved Hide resolved
src/components/dataset/entity/list.vue Outdated Show resolved Hide resolved
src/components/dataset/entity/list.vue Outdated Show resolved Hide resolved
src/components/dataset/entity/table.vue Outdated Show resolved Hide resolved
src/components/dataset/entity/list.vue Outdated Show resolved Hide resolved
@ktuite ktuite linked an issue Feb 8, 2023 that may be closed by this pull request
Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interactive review with @matthew-white

src/components/dataset/show.vue Outdated Show resolved Hide resolved
src/components/entity/list.vue Outdated Show resolved Hide resolved
src/components/entity/list.vue Outdated Show resolved Hide resolved
src/components/entity/list.vue Outdated Show resolved Hide resolved
src/components/entity/list.vue Outdated Show resolved Hide resolved
src/routes.js Outdated Show resolved Hide resolved
src/routes.js Outdated Show resolved Hide resolved
src/util/load-async.js Outdated Show resolved Hide resolved
test/components/entity/data-row.spec.js Outdated Show resolved Hide resolved
test/components/entity/table.spec.js Outdated Show resolved Hide resolved
@ktuite ktuite marked this pull request as ready for review February 23, 2023 23:53
Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interactive review of tests with @matthew-white

test/components/dataset/entities.spec.js Show resolved Hide resolved
test/data/entities.js Outdated Show resolved Hide resolved
test/data/entities.js Outdated Show resolved Hide resolved
test/data/entities.js Outdated Show resolved Hide resolved
src/routes.js Show resolved Hide resolved
@ktuite ktuite merged commit 5f01f84 into master Feb 24, 2023
@ktuite ktuite deleted the ktuite/entities-table branch February 24, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

See Entity records
2 participants