Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed gzipping large csv file on form attachments page #745

Merged

Conversation

sadiqkhoja
Copy link
Contributor

@sadiqkhoja sadiqkhoja commented Feb 28, 2023

Closes #

What has been done to verify that this works as intended?

  • Manually tested by uploading file and multiple files on form attachments page
  • All unit and integration tests are passing

Why is this the best possible solution? Were any other approaches considered?

NA

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

NA

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

NA

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@sadiqkhoja sadiqkhoja marked this pull request as ready for review February 28, 2023 03:13
@matthew-white
Copy link
Member

Just in case our future selves wonder why we made this change, we're updating nginx in getodk/central#391. As part of the update, it looks like we're going to drop support for request body decompression. That requires us to make this change to Frontend.

@sadiqkhoja sadiqkhoja merged commit 10f9874 into getodk:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants