Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update translations for v2023.4 #860

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

sadiqkhoja
Copy link
Contributor

@sadiqkhoja sadiqkhoja commented Sep 15, 2023

Progress toward #823. We'll pull translations again right before release.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@sadiqkhoja
Copy link
Contributor Author

I don't know why locale/ja.json is not updated?

@matthew-white
Copy link
Member

I don't think there's been much translation of Japanese lately, which would explain why there aren't new translations in ja.json. A few messages have been changed or removed in en.json5 as part of .4, and if they were previously translated, you'd expect to see them removed in ja.json. But it could be that they just weren't translated to begin with.

@sadiqkhoja sadiqkhoja merged commit a67c898 into getodk:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants