Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to add new property to an Entity List #963

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Apr 1, 2024

Closes getodk/central#576

Screenshot 2024-04-01 at 1 38 59 PM Screenshot 2024-04-01 at 1 39 35 PM

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interactive review with @matthew-white

src/components/dataset/overview.vue Outdated Show resolved Hide resolved
src/components/dataset/overview.vue Outdated Show resolved Hide resolved
src/components/dataset/overview/new-property.vue Outdated Show resolved Hide resolved
src/components/dataset/overview/new-property.vue Outdated Show resolved Hide resolved
src/components/dataset/overview/dataset-properties.vue Outdated Show resolved Hide resolved
test/components/dataset/overview.spec.js Outdated Show resolved Hide resolved
test/data/datasets.js Outdated Show resolved Hide resolved
@ktuite ktuite merged commit 2bb17a5 into master Apr 4, 2024
1 check passed
@ktuite ktuite deleted the ktuite/new_property branch April 4, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new property to an Entity List without publishing a Form
2 participants