Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always see Datasets tab #448

Closed
matthew-white opened this issue Jul 17, 2023 · 5 comments · Fixed by getodk/central-frontend#829
Closed

Always see Datasets tab #448

matthew-white opened this issue Jul 17, 2023 · 5 comments · Fixed by getodk/central-frontend#829
Assignees
@sadiqkhoja
Labels
behavior verified Behavior has been manually verified frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

matthew-white commented Jul 17, 2023 •
edited
Loading

See the story in the release criteria.
@matthew-white matthew-white added the frontend Requires a change to the UI label Jul 17, 2023
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Jul 17, 2023
@matthew-white matthew-white changed the title Always show the Datasets tab Always see Datasets tab Jul 18, 2023
@sadiqkhoja sadiqkhoja self-assigned this Jul 18, 2023
@matthew-white matthew-white added the needs testing Needs manual testing label Jul 18, 2023
@alyblenkin alyblenkin mentioned this issue Jul 20, 2023
Closed
@matthew-white matthew-white mentioned this issue Jul 20, 2023
Merged
2 tasks
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Jul 21, 2023
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Jul 21, 2023
@sadiqkhoja
Copy link
Contributor

@getodk/testers this can be tested on staging

@srujner
Copy link

srujner commented Aug 16, 2023

We've got two questions related to this PR:

  1. "Chip identifies it as new and interesting" - Is this about pink "New!" label next to Datasets tab?
  2. I think we need to extend the information that we give about project roles here to contains Datasets also, probably in this page too: https://docs.getodk.org/central-users/#central-users-web-roles but this might be a different PR, at the moment question is: Project Manager and Project Viewer can see the Datasets tab and Data Collector can't is this the correct behavior?
    Screenshot(152)

@sadiqkhoja
Copy link
Contributor

sadiqkhoja commented Aug 17, 2023 •
edited
Loading

"Chip identifies it as new and interesting" - Is this about pink "New!" label next to Datasets tab?

yes

Project Manager and Project Viewer can see the Datasets tab and Data Collector can't is this the correct behavior?

yes

@srujner
Copy link

srujner commented Aug 17, 2023

Tested with Success!

1 similar comment
@dbemke
Copy link

dbemke commented Aug 17, 2023

Tested with Success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadiqkhoja sadiqkhoja

Labels
behavior verified Behavior has been manually verified frontend Requires a change to the UI
Projects
ODK Central
Status: ✅ done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhances #448: show datasets tab always sadiqkhoja/central-frontend
4 participants
@sadiqkhoja @matthew-white @dbemke @srujner