Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Coming soon" from Role Settings #450

Closed
alyblenkin opened this issue Jul 20, 2023 · 7 comments · Fixed by getodk/central-frontend#834
Closed

Remove "Coming soon" from Role Settings #450

alyblenkin opened this issue Jul 20, 2023 · 7 comments · Fixed by getodk/central-frontend#834
Assignees
Labels
behavior verified Behavior has been manually verified frontend Requires a change to the UI

Comments

@alyblenkin
Copy link

Problem:
"Coming soon" has been coming soon for an eternity.

A user brought this up in a research session.

Solution:
Please remove it 🙏

Now we will have a chip for introducing new features, which I spoke to @sadiqkhoja (connected to #448 (comment))

image

@alyblenkin alyblenkin changed the title Remove "Coming soon" Remove "Coming soon" for Role Settings Jul 20, 2023
@alyblenkin alyblenkin changed the title Remove "Coming soon" for Role Settings Remove "Coming soon" from Role Settings Jul 20, 2023
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Jul 20, 2023
@matthew-white
Copy link
Member

What do you think about removing the tab entirely? I think it could be confusing if the tab is disabled without an explanation.

@alyblenkin
Copy link
Author

I think so! Having the tab is misleading when you can't do anything anyway.

@matthew-white
Copy link
Member

We don't usually show just one tab, so if we remove the "Role Settings" tab, we'd probably remove the two tabs altogether. Does that sound right?

@alyblenkin
Copy link
Author

You're right, it's not ideal to have one tab. However, we only show one tab under System, so we could get away with it for now. We plan to start designing the user evolution work soon, so I don't want it to keep changing things for users.

@matthew-white matthew-white added the needs testing Needs manual testing label Jul 25, 2023
@matthew-white matthew-white self-assigned this Jul 31, 2023
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Jul 31, 2023
matthew-white added a commit to getodk/central-frontend that referenced this issue Jul 31, 2023
matthew-white added a commit to getodk/central-frontend that referenced this issue Aug 1, 2023
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Aug 1, 2023
@matthew-white
Copy link
Member

@getodk/testers, this issue is now ready for verification. This change has been deployed to the staging server. When you navigate to the users page, you should continue to see the "Web Users" tab. However, you should not see the "Role Settings" tab.

@srujner
Copy link

srujner commented Aug 2, 2023

Tested with Success!

1 similar comment
@dbemke
Copy link

dbemke commented Aug 2, 2023

Tested with Success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified frontend Requires a change to the UI
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

4 participants