Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counts and other labels to more nav tabs #671

Closed
matthew-white opened this issue May 23, 2024 · 8 comments
Closed

Add counts and other labels to more nav tabs #671

matthew-white opened this issue May 23, 2024 · 8 comments
Assignees
Labels
behavior verified Behavior has been manually verified enhancement New feature or behavior frontend Requires a change to the UI needs design review Needs verification from designer

Comments

@matthew-white
Copy link
Member

matthew-white commented May 23, 2024

See the story in the release criteria.

@matthew-white matthew-white added enhancement New feature or behavior frontend Requires a change to the UI needs testing Needs manual testing needs design review Needs verification from designer labels May 23, 2024
@matthew-white matthew-white self-assigned this May 23, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central May 23, 2024
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Jul 2, 2024
matthew-white added a commit to getodk/central-frontend that referenced this issue Jul 5, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Jul 19, 2024
@matthew-white
Copy link
Member Author

matthew-white commented Jul 19, 2024

We may make some styling changes to the nav tabs and/or the new counts, but nothing big. I think that can come in a follow-up PR, and we can go ahead and close this issue.

@matthew-white
Copy link
Member Author

@getodk/testers, this issue is now ready to be verified on the staging server.

@dbemke
Copy link

dbemke commented Jul 25, 2024

The number in Forms tab counts drafts and published forms?

@dbemke
Copy link

dbemke commented Jul 25, 2024

Does inactive in the Public access tab mean with revoked access? I revoked access to links and the number is still visible in the tab. Should I file an issue?

Image

@matthew-white
Copy link
Member Author

The number in Forms tab counts drafts and published forms?

Yes, the number in the Forms tab should match the number of rows in the table below. For some user roles, we don't show certain forms in the table, and in that case, the number in the tab should still match the number of rows that the user can see (it should similarly not include the hidden forms). A Data Collector user can't see draft forms, and a Project Viewer can't see closing forms.

Forms in the trash should not be included in the number in the tab.

Does inactive in the Public access tab mean with revoked access?

Yes, exactly.

I revoked access to links and the number is still visible in the tab.

Ah I think that was a bug. It should be fixed now on staging.

@srujner
Copy link

srujner commented Jul 26, 2024

The number in the bubble is aligned with the text in the tab next to it, not in the bubble itself.
Screenshot(114)

@srujner
Copy link

srujner commented Jul 29, 2024

Tested with Success!

1 similar comment
@dbemke
Copy link

dbemke commented Jul 29, 2024

Tested with Success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified enhancement New feature or behavior frontend Requires a change to the UI needs design review Needs verification from designer
Projects
Status: ✅ done
Development

No branches or pull requests

3 participants