Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pm2 to latest version #386

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Update pm2 to latest version #386

merged 1 commit into from
Feb 27, 2023

Conversation

matthew-white
Copy link
Member

@matthew-white matthew-white commented Feb 15, 2023

This PR updates pm2 to the latest version.

What has been done to verify that this works as intended?

I haven't done much to verify this change to the patch version. If there is an issue, then CircleCI or regression testing should help catch it.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No change needed.

Before submitting this PR, please make sure you have:

  • verified that any code or assets from external sources are properly credited in comments.

@matthew-white matthew-white added the maintenance Dependencies, recurring maintenance label Feb 15, 2023
@matthew-white matthew-white self-assigned this Feb 15, 2023
Copy link
Contributor

@sadiqkhoja sadiqkhoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to verify that multiple instances of pm2 are running on dev/test environment

@matthew-white
Copy link
Member Author

It would be nice to verify that multiple instances of pm2 are running on dev/test environment

How have you done that in the past? Could we check for that in the central CircleCI?

@matthew-white
Copy link
Member Author

I think I'm going to go ahead and merge. If we're going to verify this, I think it'd be best to do so in CircleCI. (This won't be the last time that we update pm2!) @sadiqkhoja, let me know if you have thoughts about how to do that!

@matthew-white matthew-white merged commit c17947f into next Feb 27, 2023
@matthew-white matthew-white deleted the update-pm2 branch February 27, 2023 20:13
yanokwa pushed a commit that referenced this pull request Feb 27, 2023
@matthew-white
Copy link
Member Author

matthew-white commented Feb 28, 2023

From @sadiqkhoja: Go into the service container. There is a command related to pm2 that can be used to check this.

docker-compose exec -it service bash
pm2 list # ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependencies, recurring maintenance
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

2 participants