Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node #415

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Upgrade node #415

merged 2 commits into from
Mar 24, 2023

Conversation

yanokwa
Copy link
Member

@yanokwa yanokwa commented Mar 16, 2023

Follow on from #390

@yanokwa yanokwa requested a review from lognaturel March 16, 2023 22:38
@matthew-white matthew-white changed the base branch from master to next March 21, 2023 22:36
@lognaturel
Copy link
Member

I think we could do

ARG node_version=16.19.1
FROM node:${node_version}

would need to be verified. Alternately, a comment above the intermediary container node version might be sufficient.

@yanokwa yanokwa marked this pull request as ready for review March 21, 2023 22:59
@lognaturel
Copy link
Member

I pulled this branch on dev, built, then docker exec central-service-1 node --version. I believe this usage of ARG is common.

@lognaturel lognaturel merged commit 6099c98 into getodk:next Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lognaturel lognaturel lognaturel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanokwa @lognaturel