Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End page buttons not aligned properly on older devices in RTL #6362

Closed
dbemke opened this issue Aug 21, 2024 · 4 comments · Fixed by #6489
Closed

End page buttons not aligned properly on older devices in RTL #6362

dbemke opened this issue Aug 21, 2024 · 4 comments · Fixed by #6489
Assignees
Milestone

Comments

@dbemke
Copy link

dbemke commented Aug 21, 2024

ODK Collect version

the store version 2024.2.3, the master version 30f759c

Android version

10, 11, 8.1

Device used

Redmi 9T, Galaxy M12, Nexus 5X

Problem description

When RTL language is set in Collect the "Save as draft" and "Finalize/Send" buttons at the end page of a form are aligned to the right (part of the "Save as draft" button is cut).
saveAsDRaftButtonRtl
The issue doesn't occur on Pixel 7a (Android 14).

  1. Set an RTL language in Collect.
  2. Go to e.g. All widgets form to the end page.

Expected behavior

Whole buttons should be visible on all devices.

@dbemke dbemke changed the title End page button not aligned properly on older devices in RTL8.1s End page buttons not aligned properly on older devices in RTL8.1s Aug 21, 2024
@dbemke dbemke changed the title End page buttons not aligned properly on older devices in RTL8.1s End page buttons not aligned properly on older devices in RTL Aug 21, 2024
@seadowg seadowg added this to the v2024.4 milestone Aug 28, 2024
@lognaturel
Copy link
Member

@karntrehan will take a look!

@grzesiek2010
Copy link
Member

We agreed that if it isn’t done by Thursday, we should take over to ensure it’s included in v2024.3. I’ll take a look at it.

@karntrehan
Copy link

@grzesiek2010 I see that you have raised a PR for this already. Should I still look into this? What is pending?

@grzesiek2010
Copy link
Member

@grzesiek2010 I see that you have raised a PR for this already. Should I still look into this? What is pending?

No, as mentioned above, we aimed to complete it earlier that's why I took over, and it's now done and awaiting testing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

5 participants