Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL issue with buttons on end of form send/finalize screen #6479

Closed
lognaturel opened this issue Oct 28, 2024 · 4 comments
Closed

RTL issue with buttons on end of form send/finalize screen #6479

lognaturel opened this issue Oct 28, 2024 · 4 comments

Comments

@lognaturel
Copy link
Member

https://forum.getodk.org/t/ui-button-layout-misalignment-with-rtl-languages/50436/2

@lognaturel
Copy link
Member Author

@karntrehan this should be a straightforward issue that would be valuable to get fixed if you're interested!

@karntrehan
Copy link

Would love to pick this up @lognaturel. Thank you for thinking of me.

A few questions:

  1. Should we flip the icons or not?
  2. Should we center align text always? Irrespective or LTR to RTL?

@lognaturel
Copy link
Member Author

Let's not change the icon flipping as part of the issue. Yes, the text should always be center aligned.

@dbemke mentioned this was already filed at #6362! Closing in favor of that one. Do note that it doesn't happen on every device. If it doesn't look like an easy fix, let's talk about what to do.

@tiritea
Copy link

tiritea commented Oct 29, 2024

Do note that it doesn't happen on every device.

Guess I got 'lucky', huh? ... :-)

FWIW, this was on a Samsung Galaxy A12 running Android 12/API 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: done
Development

No branches or pull requests

3 participants