Skip to content

Commit

Permalink
Use existing porter.yaml for testing and remove the other one
Browse files Browse the repository at this point in the history
Signed-off-by: joshuabezaleel <[email protected]>
  • Loading branch information
joshuabezaleel committed Feb 22, 2022
1 parent 9131e9b commit 3f7dd79
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 29 deletions.
2 changes: 1 addition & 1 deletion pkg/porter/build_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func TestPorter_BuildWithCustomValues(t *testing.T) {
p := NewTestPorter(t)
defer p.Teardown()

p.TestConfig.TestContext.AddTestFile("./testdata/porter-with-custom-values.yaml", config.Name)
p.TestConfig.TestContext.AddTestFile("./testdata/porter.yaml", config.Name)

err := p.LoadManifestFrom(config.Name)
require.NoError(t, err)
Expand Down
24 changes: 0 additions & 24 deletions pkg/porter/testdata/porter-with-custom-values.yaml

This file was deleted.

11 changes: 7 additions & 4 deletions pkg/porter/testdata/porter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ version: 0.1.0
description: "A bundle with a custom action"
registry: getporter

custom:
customKey1: "customValue1"

credentials:
- name: my-first-cred
env: MY_FIRST_CRED
Expand Down Expand Up @@ -50,10 +53,10 @@ mixins:

install:
- exec:
description: "Install Hello World"
command: bash
flags:
c: echo Hello World
description: "Install Hello World with custom arguments"
command: echo
arguments:
- "{{ bundle.custom.customKey1 }}"

upgrade:
- exec:
Expand Down

0 comments on commit 3f7dd79

Please sign in to comment.