-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quickstart doc for porter configuration file #2038
Conversation
Signed-off-by: Yingrong Zhao <[email protected]>
try out porter with bundles that contain sensitive data, copy and paste below code into the | ||
configuration file: | ||
```yaml | ||
default-secrets-plugin = "filesystem" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, all of your config examples are TOML, not YAML. Pick which language you'd like to show (I think yaml would be better since porter.yaml is yaml too), and then update the code fence / examples to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed
/azp run porter-integration |
Commenter does not have sufficient privileges for PR 2038 in repo getporter/porter |
Signed-off-by: Yingrong Zhao <[email protected]>
2f540f9
to
f364244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some real small fixups and this is good to go! 🏇 💨
Signed-off-by: Yingrong Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this change
This PR adds a new quickstar documentation for porter's configuration file
What issue does it fix
adds documentation #1027
Notes for the reviewer
Preview can be found here: https://deploy-preview-2038--porter.netlify.app/quickstart/configurations/
Checklist
Reviewer Checklist