Add failing test case for parameter with output source #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it possible to access a parameter in templating, not
only to the top-level, i.e. the parameter itself, but also -- if the
parameter is of type "object" -- to access properties of the object
value. For example:
```yaml
parameters:
- name: foo
type: object
default:
a: 1
b: 2
install:
mymixin:
some_property: ${ bundle.parameters.foo.a }
```
In this case, the `.a` was not possible before as `foo` was merely a
JSON string at the point of template resolution.
Signed-off-by: Leo Bergnéhr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an output source to the cnab bundle specification makes the parameter disappear from
porter explain.This fails the test:
TestExplain_generateTable.TBD:
What does this change
What issue does it fix
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist
Reviewer Checklist