Fixing failure report rendering #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing return statement to actually bring the rendered HTML back to `send_failure_report`. This was fine basically everywhere else since it used Flask's version of render_template, but for this more custom case, the string needs to be returned back to be inside the email.
|
Sorry didn't mean to generate another PR, didn't know renaming the branch would auto-close the other one, TIL. |
6 tasks
arikfr
approved these changes
May 14, 2021
|
Thanks! |
lotreal
added a commit
to lotreal/redash
that referenced
this pull request
Jun 22, 2021
* master: remove redundant fields from slack alert destination (getredash#5514) README.md: Add TiDB to the Supported Data Sources (getredash#5477) Refine Dockerfile caching (getredash#5484) fix big_query.py google api import error (getredash#5482) Use the correct rq connection in `get_queues_status` (getredash#5491) Fixing failure report rendering (getredash#5492) SFS-001: Adding support for the optional host connection property (getredash#5490) Expire sessions after 6 hours of inactivity (getredash#5159) use ptpython instead of standard python shell (getredash#5483) Adds rate limit to /forgot. (getredash#5425) Athena: skip tables with no StorageDescriptor (getredash#5447)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Missing return statement to actually bring the rendered HTML back to send_failure_report. This was fine basically everywhere else since it used Flask's version of render_template, but for this more custom case, the string needs to be returned back to be inside the email.
Related Tickets & Documents
#5093
Mobile & Desktop Screenshots/Recordings (if there are UI changes)