Add environment variable to override secure_flag on session cookie #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +122,8 @@ def all_settings(): | |||
|
|
|||
| JOB_EXPIRY_TIME = int(os.environ.get("REDASH_JOB_EXPIRY_TIME", 3600 * 6)) | |||
| COOKIE_SECRET = os.environ.get("REDASH_COOKIE_SECRET", "c292a0a3aa32397cdb050e233733900f") | |||
| SESSION_COOKIE_SECURE = os.environ.get("REDASH_SESSION_COOKIE_SECURE", False) | |||
There was a problem hiding this comment.
- You should wrap it with
parse_booleanlike we do for the other boolean values (or it will be the string "True"/"true" instead of boolean value). - I think a nice default would be to set this to the value of
ENFORCE_HTTPS. What do you think?
|
Thanks! |
Also wraps parse_boolean around the os.get call for the secure_flag variable
|
Hey @arikfr. Thanks for the feedback. I have incorporated it. Let me know what you think. |
|
👍 |
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Add environment variable to override secure_flag on session cookie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates an environment variable that allows Developers to set the secure flag[1] on browser cookies. By default, this is set to False by flask[2].