Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elixir): Use asdf to install erlang and elixir #479

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

sl0thentr0py
Copy link
Member

No description provided.

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) July 25, 2023 12:44
@sl0thentr0py sl0thentr0py merged commit d45ba96 into master Jul 25, 2023
8 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/elixir-asdf branch July 25, 2023 12:46
@asottile-sentry
Copy link
Member

hi -- can we please wait a little bit so the repository owners can review things before making major changes like introducing a whole plugin ecosystem? asdf is quite heavy handed for this and there's more direct solutions that'll be easier to maintain in the long run

@sl0thentr0py
Copy link
Member Author

sl0thentr0py commented Jul 25, 2023

I already tried the other route which caused the npm target to break. Bottom line is I want to unblock a contractor who's been waiting on this for upwards of 3 weeks now and I do not have time to go through all the dependencies / targets and see what breaks in that environment (nor is there any easy way of testing all the targets against the docker image).
All of this requires better tooling but I believe neither the SDK team nor dev infra has time for all that, so this is the quickest way forward.

I can wait in the future for reviews, sure but fwiw craft feels like it has no clear owner for larger feature requests etc.

@asottile-sentry
Copy link
Member

craft is owned by dev-infra. this patch increases the docker image by 20% which is pretty significant for one language.

@sl0thentr0py
Copy link
Member Author

do you have a concrete viable alternative that unblocks me?

@asottile-sentry
Copy link
Member

searching the elixir installation page they recommend the precompiled package

@sl0thentr0py
Copy link
Member Author

you need erlang/otp too which is too old on this debian

@asottile-sentry
Copy link
Member

the elixir page also links to downloads for erlang as well here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants