Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Patches #1

Open
wants to merge 549 commits into
base: master
Choose a base branch
from
Open

Sentry Patches #1

wants to merge 549 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Dec 15, 2022

  1. [client] New class LengthDelimitedRingBuffer

    This CL implements LengthDelimitedRingBuffer, a general-purpose
    ringbuffer suitable for use as a Crashpad Annotation.
    
    This ringbuffer supports writing variably-sized data delimited by a Base
    128 varint-encoded length separator.
    
    LengthDelimitedRingBuffer is backed by a std::array, so it has a fixed
    maximum size. It supports reading via RingBufferReader as well as
    writing via RingBufferWriter.
    
    Change-Id: I23ecb4a85ee8e846e1efc6937a5cb089a494d50a
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4023618
    Reviewed-by: Robert Sesek <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1a7918b View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Roll gn to 5e19d2fb.

    GN now does more iOS xcode project generation natively.
    
    Change-Id: I0a133e648a9426cfc822e40af36c2626ddb58f68
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4111089
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    0e7dae4 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. [ios] Support --gtest_filter for iOS tests

    Change-Id: I5511911110b58b7accd0f78cc1094924bfbda71e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4114702
    Reviewed-by: Justin Cohen <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    62a0099 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. [ios] Fix --gtest_filter for non-xcuitest targets

    Change-Id: I477919feec68d317ca3cb8a0d07022e9405156dd
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4118347
    Reviewed-by: Justin Cohen <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    bd479a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. [fuchsia] Update crashpad location

    ... as we move crashpad from //third_party/crashpad to
    //third_party/crashpad/src
    
    Change-Id: I081520ad44334cc83397234e5d16535d0db4806d
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4132465
    Reviewed-by: Francois Rousseau <[email protected]>
    Commit-Queue: Jay Zhuang <[email protected]>
    jayzhuang authored and Crashpad LUCI CQ committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    a41e599 View commit details
    Browse the repository at this point in the history
  2. mac: Don’t cater to gcc-4.2 libstdc++ brokenness

    The try and catch macros were conditionally defined by libstdc++ pre-gcc
    4.4 (2009-04-21), fixed in
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25191. Surely none of this
    code would build with such an old libstdc++ any more, since Crashpas has
    adopted modern C++ (C++11 and later). Remove this obsolete nod to
    history.
    
    Change-Id: Ie3cea1ecc1cfd358f27ea48f8111791e7f08bfa5
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4136890
    Reviewed-by: Robert Sesek <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    markmentovai authored and Crashpad LUCI CQ committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    2103586 View commit details
    Browse the repository at this point in the history
  3. [snapshot] Use Fuchsia specific header

    ... when compile target is Fuchsia
    
    Change-Id: Id77babbd3dffff26c75a52296ac91101780e4c33
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4132464
    Reviewed-by: Francois Rousseau <[email protected]>
    Commit-Queue: Jay Zhuang <[email protected]>
    jayzhuang authored and Crashpad LUCI CQ committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    a0b4e88 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. [fuchsia] Import buildconfig from fuchsia

    ... when build is targeting Fuchsia
    
    Change-Id: I03fab9368bd5e8687899a2efeb51736707bce81e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4137733
    Commit-Queue: Jay Zhuang <[email protected]>
    Reviewed-by: Francois Rousseau <[email protected]>
    jayzhuang authored and Crashpad LUCI CQ committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    43eac93 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Update header includes for /base/functional in Crashpad

    bind.h, callback.h, callback_forward.h, and callback_helpers.h
    moved into /base/functional/. Update the include paths to
    directly include them in their new location.
    
    Bug: chromium:1364441
    Change-Id: I23aaa16644c10ac5b607ea29d25799fbb08dfaca
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4163072
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Avi Drissman <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    1e10a23 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. fix: upload crashes on linux (#75)

    Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
    BogdanLivadariu and supervacuus authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    4edb2bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    918fd31 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. [fuchsia] Temporarily disable hwasan from crashpad tests

    Much of crashpad's unittests propagate tagged pointers to fuchsia
    syscalls which do not accept tagged values. Rather than fixing them all
    right now, just ensure that the tests do not build with the hwasan
    variant if enabled.
    
    Bug: fxbug.dev/108368
    Change-Id: Ib32eb95ba671a6b55694075b68c7fbbb733cf501
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4175438
    Reviewed-by: Francois Rousseau <[email protected]>
    Commit-Queue: Francois Rousseau <[email protected]>
    PiJoules authored and Crashpad LUCI CQ committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    84627e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    a0ab0e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Mac: Look for crash annotations in __DATA_DIRTY on macOS 13+

    Bug: chromium:1373664
    Change-Id: I948eac3a46e8ad0d6fe70413111641e77c7ae57c
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4196074
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Leonard Grey <[email protected]>
    speednoisemovement authored and Crashpad LUCI CQ committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    ad2e043 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3dc58f4 View commit details
    Browse the repository at this point in the history
  3. win32: Ensure InitializeContext2 definition availability

    On both mingw and MSVC (when targeting < Windows 10)
    past-due committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    cc4a6ae View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Mac: more robust __crash_info on 13+

    It looks like macOS 13 only *sometimes* puts __crash_info in
    __DATA_DIRTY. Instead of splitting by version check, let's just look
    in __DATA_DIRTY if we can't find it in __DATA.
    
    Bug: chromium:1372165
    Change-Id: I99d2e759c66841d982039449e83f8658259d7ed1
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4197706
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Leonard Grey <[email protected]>
    speednoisemovement authored and Crashpad LUCI CQ committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    85b7d3d View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. mingw: WER support

    past-due committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    b66ab3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    817cb65 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    59b37de View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Add a mask to MinidumpCrashpadInfo to indicate valid pointer addresses.

    ARM64 supports storing pointer authentication codes in the upper bits of
    a pointer. This mask can be used by LLDB to mimic ptrauth_strip and
    strip the pointer authentication codes. To recover an address from
    pointer with an authentication code, `AND` this mask with the pointer.
    
    If the platform does not support pointer authentication, or the range of
    valid addressees for a pointer was unaccessible, this field will be 0
    and should be ignored.
    
    Change-Id: Ie5cef90802dd1e892d456195ab8874223eac6a1b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2773358
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c11d49d View commit details
    Browse the repository at this point in the history
  2. [client] Clean up types and code style in LengthDelimitedRingBuffer

    This CL cleans up types and code style comments from post-submit code
    review comments on https://crrev.com/c/4023618 .
    
    I also added fixes for potential overflows in varint length decoding
    and included new tests.
    
    Bug: crashpad:437
    Change-Id: I0a3585036028d81f42d0d36e87cce4264f4ed9ad
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4199705
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Justin Cohen <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8071d30 View commit details
    Browse the repository at this point in the history
  3. [ios] New class ScopedVMMap

    This CL introduces a new class ScopedVMMap, a fork of ScopedVMRead
    which maps the memory using vm_remap() instead of reading it.
    
    This is useful for Annotations which use ScopedSpinGuard to
    protect reads from simultaneous writes; the in-process intermediate
    dump handler can try to take the spin guard when reading such
    an Annotation and skip reading it if it the spin guard could not
    be obtained.
    
    Change-Id: I60d7a48d1ba4e5d2dfdb44307b78b4d9ffb73560
    Bug: crashpad:437
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4114550
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    28354d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. handle num_handled_exceptions == 0 case

    from documentation of `ProcessException` in `crashpad_wer.h`:
    
    ```
    //! \param[in] handled_exceptions is an array of exception codes that the helper
    //!     should pass on to crashpad handler (if possible). Pass nullptr and set
    //!     num_handled_exceptions to 0 to pass every exception on to the crashpad
    //!     handler.
    ```
    
    fix the check to handle `num_handled_exceptions == 0` case to not filter
    out any exceptions.
    
    Bug: crashpad:439
    Change-Id: Ic4559a730a26e37c7a8f13e6bcae7595d743924a
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4206503
    Commit-Queue: Alex Gough <[email protected]>
    Reviewed-by: Alex Gough <[email protected]>
    vnagarnaik authored and Crashpad LUCI CQ committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    9158eb7 View commit details
    Browse the repository at this point in the history
  2. [client] Optionally support ScopedSpinGuard in Annotation

    This CL optionally integrates ScopedSpinGuard (an atomic boolean) with
    crashpad::Annotation.
    
    Subclasses of Annotation can choose to integrate ScopedSpinGuard into
    their Set(...) methods to ensure reads and writes are serialized.
    
    I didn't integrate this into StringAnnotation in this CL, but it'd be
    pretty trivial to do in a follow-up.
    
    Change-Id: I1c5b8982576b03f9780a57acb7627c9194f8f0ff
    Bug: crashpad:437
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4022484
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    3215ed9 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. [client] New RingBufferAnnotation

    This CL integrates the new ScopedSpinGuard with the new
    LengthDelimitedRingBuffer into a new class, RingBufferAnnotation.
    
    RingBufferAnnotation is thread-safe both for reading and writing, and is
    suitable for streaming logs, trace events, and other high-throughput
    data streams.
    
    I included a load test (ring_buffer_annotation_load_test) which launches
    two threads which simultaneously write to and read from the
    RingBufferAnnotation.
    
    By default, reads and writes are serialized using ScopedSpinGuard, but
    passing the flag "--disable_spin_guard" to the test disables the spin
    guard on the reading side (which is expected to make the test fail).
    
    Change-Id: Ic8e28866d085d57e778c4f86bcb7492ef0638ab9
    Bug: crashpad:437
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4023619
    Reviewed-by: Robert Sesek <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    212b8f6 View commit details
    Browse the repository at this point in the history
  2. [ios] Support guarding concurrent reads and writes to Annotations

    Since iOS reads Annotations in-process, this CL updates the iOS
    intermediate dump handler to check each Annotation to see if it supports
    guarding concurrent reads and writes using ScopedSpinGuard.
    
    For any such Annotation, the in-process dump handler now tries (without
    spinning) to obtain the ScopedSpinGuard for the Annotation before
    reading its memory.
    
    If the ScopedSpinGuard cannot immediately be obtained, the in-process
    dump handler just skips writing the memory of the Annotation to the
    intermediate dump. (I'd like to follow up and thread down a Params
    object so we can experiment with adding an optional timeout to make
    this more reliable.)
    
    Change-Id: Ie6c9849fac94ab89b36364b07aea62326cabe552
    Bug: crashpad:437
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4031730
    Commit-Queue: Ben Hamilton <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    c7d9c71 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Configuration menu
    Copy the full SHA
    08ec71c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    981e164 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Configuration menu
    Copy the full SHA
    486c293 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Merge pull request #79 from supervacuus/fix/curl_found_crashpad_linux

    fix: make sure we reuse already found libcurl
    supervacuus authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    3a3c1f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5886ae4 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #78 from past-due/mingw-patches-1

    mingw compilation fixes
    supervacuus authored Feb 6, 2023
    Configuration menu
    Copy the full SHA
    e39c0b6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ad3404f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3af012a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Merge pull request #80 from supervacuus/meta/update

    meta: update 2023-02-07
    supervacuus authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ec99257 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. ios: Validate exception code buffer size before read.

    Bug: 1415371
    Change-Id: I9e1bd902494a664d4f07829e686803712fa8e7a8
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4255568
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    0adab59 View commit details
    Browse the repository at this point in the history
  2. Fix test that relied on NDEBUG always disabling DCHECK

    The test BaseAnnotationShouldNotSupportSpinGuard assumed NDEBUG builds
    always disabled DCHECK()s, but DCHECK_ALWAYS_ON overrides this.
    
    This CL fixes the test for NDEDBUG + DCHECK_ALWAYS_ON builds by using
    the DCHECK_IS_ON() macro to skip the test when DCHECKs are enabled.
    
    Change-Id: I7b64729568c5d3139ca777e27462d81eba931834
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4255429
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    485805c View commit details
    Browse the repository at this point in the history
  3. port: fix non-glibc desktop linux build

    This is the only change needed to build crashpad against musl, yay! The
    reason this change is needed is that user_vfp is bionic-specific, and
    does not exist in glibc, dietlibc, uclibc, or musl.
    
    I have not (yet) tried running the tests against another libc.
    
    Bug: chromium:1380656
    Change-Id: I2247352e1611a300dff995156d393508c8257039
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4255370
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Elly Fong-Jones <[email protected]>
    Elly Fong-Jones authored and Crashpad LUCI CQ committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    04b2ab5 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Fix StringPiece compile issue in Chromium.

    Change-Id: I5a29f690a4512252d0d5730492f7fd4cec16ffaa
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4262547
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Justin authored and Crashpad LUCI CQ committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    70e0f92 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. win: Only process up to EXCEPTION_MAXIMUM_PARAMETERS in an EXCEPTION_…

    …RECORD
    
    The EXCEPTION_RECORD contains a NumberParameters field, which could
    store a value that exceeds the amount of space allocated for the
    ExceptionInformation array.
    
    Bug: chromium:1412658
    Change-Id: Ibfed8eb6317e28d3addf9215cda7fffc32e1030d
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4284559
    Reviewed-by: Alex Gough <[email protected]>
    Commit-Queue: Robert Sesek <[email protected]>
    rsesek authored and Crashpad LUCI CQ committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    3e87272 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Add dump_minidump_annotations

    Adds the dump_minidump_annotations tool (modified from jperaza's WIP
    code). This works similarly to Breakpad's minidump_dump tool, but:
    
    1. Is available on Windows
    2. Only dumps simple/vectored annotations and annotation objects instead
       of the entire minidump contents.
    
    Current use case for this is to be able to get a minidump's process
    type on Windows without having to go through symbolization, but there
    may be other use cases in the future.
    
    Bug: chromium:1006331
    Change-Id: I392024e230c10ea18673b3cf0d0ad4793d21f5eb
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4287994
    Reviewed-by: Joshua Peraza <[email protected]>
    Commit-Queue: Brian Sheedy <[email protected]>
    bsheedy authored and Crashpad LUCI CQ committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    448d2d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. fix: remove the OpenSSL dependency for Linux

    Since we no longer use `http_transport_socket` on Linux there is no
    need to depend on OpenSSL directly anymore. We use whatever the present
    `libcurl` implementation uses as its TLS implementation.
    
    Also moved the dependency discovery for Android (which we currently do
    not use) to `crashpad-util` to isolate it to its usage.
    supervacuus committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ee62397 View commit details
    Browse the repository at this point in the history
  2. Report exception number in metadata on CrOS.

    In order to determine in crash_reporter whether a crash was fatal, we
    need the exception number (-1 is not an actual crash).
    
    BUG=b:269159625
    TEST=deploy to DUT; chrome://crashdump; verify metadata present.
    
    Change-Id: I83d3c9cc839a685af2f50d143d627cf9fcfaf3ac
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4265253
    Reviewed-by: Joshua Peraza <[email protected]>
    Commit-Queue: Miriam Zimmerman <[email protected]>
    mutexlox authored and Crashpad LUCI CQ committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    7a997fb View commit details
    Browse the repository at this point in the history
  3. ios: Suppress log-if-missing for kSourceVersion intermediate dump key.

    It's not required that LC_SOURCE_VERSION be present in every module, and
    common for it to be missing. Suppress recording its absence.
    
    Fixed: crashpad:443
    Change-Id: Iae10c38c78514e78af6c3176cc809d95a3ae3811
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4294861
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    9830fbf View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Merge pull request #81 from supervacuus/fix/remove_openssl_dep_on_linux

    fix: remove find_package(OpenSSL)  for Linux builds
    supervacuus authored Feb 28, 2023
    Configuration menu
    Copy the full SHA
    2237d97 View commit details
    Browse the repository at this point in the history
  2. Fix some accidental uses of argument-dependent lookup

    StringToInt(string_piece) works because base::StringPiece is in
    namespace base, but when it is switched to std::string_view, this won't
    work anymore. Use the idiomatic spelling.
    
    Bug: chromium:691162
    Change-Id: Ic45e0d2729fa5fc7c3e7a56fe159957b1bdcdf94
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4298113
    Commit-Queue: David Benjamin <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    davidben authored and Crashpad LUCI CQ committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    90bba04 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Restrict new crash_reporter flag to valid versions

    Lacros can be up to 2 milestones ahead of ash (and consequently the
    platform code), so until the crash_reporter change has been in for 2
    milestones, we need to manually check version compatibility.
    
    BUG=chromium:1420445
    TEST=Build, deploy, check that flag is set only on right version
    
    Change-Id: Ic99d5ac58840814f7eeecd47c628ea0e8107f675
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4308129
    Commit-Queue: Mark Mentovai <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    mutexlox authored and Crashpad LUCI CQ committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    707d0d4 View commit details
    Browse the repository at this point in the history
  2. ios: Support minimum deployment targets of iOS15

    The windows property of UIApplication is unavailable in iOS15.
    
    Bug: 1406561 crashpad:
    Change-Id: I19642067a13801142cd3f24586bab6958a81635d
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4304398
    Reviewed-by: Justin Cohen <[email protected]>
    Commit-Queue: Joemer Ramos <[email protected]>
    Joemer Ramos authored and Crashpad LUCI CQ committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    3e54a2c View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Use thread_local instead of ThreadLocalStorage::Slot.

    This also significantly simplifies the implementation, since we don't
    really need the ThreadLogMessagesMaster class at all.
    
    Bug: chromium:1416710
    Change-Id: I85849230015f901dfbf084d140e639f14cb872a7
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4313281
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Kasting <[email protected]>
    pkasting authored and Crashpad LUCI CQ committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    322eaa5 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. ios: Fix crash in ObjcExceptionPreprocessor.

    ObjcExceptionPreprocessor is a 'reasonable effort' attempt to catch an
    NSException minidump at time the exception is thrown as opposed to when the application terminates due to the exception. If multiple
    exceptions are thrown at the same time, Crashpad should correctly
    report the final uncaught exception, but the minidump may not
    represent the full `caught-at-thrown` minidump.
    
     - Don't assume ObjcExceptionPreprocessor throws an NSException.
     - Don't retain/release the exception. Instead of calling isEqual,
       just use a simple pointer comparison.
     - Make last_exception atomic.
    
    Bug: crashpad: 445, 446
    Change-Id: I9f2f2041e96aa9818c63937025e507487ae9d03d
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4317110
    Reviewed-by: Ben Hamilton <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    3cd7b5b View commit details
    Browse the repository at this point in the history
  2. Fix another argument-dependent-lookup dependency

    Missed this the first time around because it was Windows-only.
    
    Bug: chromium:691162
    Change-Id: Ic98a5943957f77fbf17d92a93409eaa35910ae0e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4297482
    Commit-Queue: David Benjamin <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    davidben authored and Crashpad LUCI CQ committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d5b2eea View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Raise extra-memory cap in ProcessSnapshotTest.CrashpadInfoChild

    The extra_memory cap in ProcessSnapshotTest.CrashpadInfoChild is not
    high enough to avoid test failures on all machines. The actual amount
    recorded has been seen to vary between 726,556 and 1,152,803. This
    change rases the limit from 1,000,000 to 1,200,000 to avoid the
    failures.
    
    The highest amount was seen on a 64-GB gWindows ThinkPad laptop.
    
    Instrumentation shows that the low and high cases both have 104 threads.
    The low case has 304 ExtraMemory() blocks, whereas the high case has
    409. In both cases the sizes range from 384 to 6,024.
    
    Change-Id: I8873921fa913c31445384db34d4aa90200401a4a
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4348802
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Bruce Dawson <[email protected]>
    randomascii authored and Crashpad LUCI CQ committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    eeb3cad View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Skip tests that create symbol links when not allowed

    Several tests in filesystem_test.cc create symbol links. The privilege
    needed to do this is not enabled on all Windows systems so several of
    the tests check for the privilege and are skipped if it is not
    available.
    
    However, two tests that created symbol links were not doing this check
    and therefore failed on some Windows machines. This corrects those
    failures by adding the checks.
    
    Bug: chromium:1418165
    Change-Id: I6621796b462b8db02271ad5a05e0c29ee047f648
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4348801
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Bruce Dawson <[email protected]>
    randomascii authored and Crashpad LUCI CQ committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    fdf7b9e View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Fix iOS test with libc++ exception throw change.

    After https://reviews.llvm.org/D141222 exceptions call into
    __libcpp_verbose_abort, which Chromium sets to `brk 0` in release.
    
    Bug: 1425429
    Change-Id: Ie00d1317bb03fcb1f15fb5c41ab69640dfb564b7
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4347775
    Reviewed-by: Robert Sesek <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c21292d View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Crashpad: Adding PAC bit stripping to stack sanitization.

    Pointer Authentication works by adding a signature to the top bits of
    an instruction or data pointer (only instruction pointers on the stack
    are currently signed in Chromium). This can confuse range checks,
    because they need to strip the top bits. Masking these bits during sanitization range checks prevents confusion.
    
    
    Test: Testing was done manually on a device with pointer authentication enabled.
    Bug: crashpad:364
    Bug: 919548
    Change-Id: I2e739cadb2844cfaf73a75596d664135aeb5faac
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4387271
    Commit-Queue: Adam Walls <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    Reviewed-by: Ben Hamilton <[email protected]>
    avvall authored and Crashpad LUCI CQ committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    4773a37 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. ios: Always reset IOSIntermediateDumpWriter file descriptor on close.

    Always reset the file descriptor to -1, even if FlushWriteBuffer or
    RawLoggingCloseFile fails.
    
    Bug: 1431760
    Change-Id: I193f526d65f477bba002dd9faf68996020e48a3b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4406657
    Reviewed-by: Ben Hamilton <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    ada8dfa View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. pac_helper: test for __has_feature macro

    __has_feature is a clang extension. GCC errors out on the test.
    Define a helper macro to make the code working with other compilers.
    
    Bug: chromium:819294
    Change-Id: I359150acd4700e65b4faf5f297b29664c18000d3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4418706
    Reviewed-by: Joshua Peraza <[email protected]>
    Commit-Queue: Joshua Peraza <[email protected]>
    Reviewed-by: Ben Hamilton <[email protected]>
    stha09 authored and Crashpad LUCI CQ committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    0e3758b View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. [tests] Disable clang optimization on the infinite recursion function.

    In the recent llvm upstream change, https://reviews.llvm.org/D148269,
    clang becomes smarter and will remove the infinite recursion function.
    Use the clang attribute __attribute__((optnone)) to disable optimization
    for it.
    
    Bug: chromium:1435016
    Change-Id: I74e823bf64d0b03d81c0bda7a8338e2fa67033aa
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4456156
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Zequan Wu <[email protected]>
    ZequanWu authored and Crashpad LUCI CQ committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3a6bc8c View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Remove base/cxx17_backports.h from the code in third_patry/crashpad

    Remove the reference to `base/cxx17_backports.h` from the code.
    
    Bug: chromium:1373621
    Change-Id: I84dd5fc1b069b168e4558316344c1f1c5377a68b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4471860
    Commit-Queue: Mark Mentovai <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    gz83 authored and Crashpad LUCI CQ committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    07827d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Configuration menu
    Copy the full SHA
    7f9c460 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Configuration menu
    Copy the full SHA
    fbd4abe View commit details
    Browse the repository at this point in the history
  2. Add dump_minidump_annotations to tools build.

    Also: clean up and fix the failing tool-build on macOS.
    supervacuus committed May 3, 2023
    Configuration menu
    Copy the full SHA
    56b62ee View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Add tools to CI build

    supervacuus committed May 4, 2023
    Configuration menu
    Copy the full SHA
    fc014d9 View commit details
    Browse the repository at this point in the history
  2. Fix windows tool build

    supervacuus committed May 4, 2023
    Configuration menu
    Copy the full SHA
    36b0f0d View commit details
    Browse the repository at this point in the history
  3. Merge pull request #82 from supervacuus/meta/update

    meta: update 2023-05-03
    Swatinem authored May 4, 2023
    Configuration menu
    Copy the full SHA
    1904ae1 View commit details
    Browse the repository at this point in the history
  4. meta: Add codeowners

    ashwoods committed May 4, 2023
    Configuration menu
    Copy the full SHA
    53c2ede View commit details
    Browse the repository at this point in the history
  5. Merge pull request #83 from getsentry/add-codeowners

    meta: Add codeowners
    supervacuus authored May 4, 2023
    Configuration menu
    Copy the full SHA
    3b82866 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Update linux-syscall-support (LSS) version

    Newer versions of LSS include support for RISC-V.
    
    Fixed: fuchsia:125946
    Change-Id: Iab65174e9a5f2a7075faadd34dc54b0c23ce3da4
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4510030
    Reviewed-by: Joshua Peraza <[email protected]>
    thomasgales authored and Joshua Peraza committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a280d65 View commit details
    Browse the repository at this point in the history
  2. Fix ASan failures for MinidumpCrashpadInfoWriter

    Fuchsia AddressSanitizer tests were failing because of unaligned memory
    access in several unit tests.
    
    Fixed: fuchsia:125877
    Change-Id: If577ea9b7be24ef40865a637d8f6b6d94daaeb67
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4510016
    Reviewed-by: Joshua Peraza <[email protected]>
    thomasgales authored and Joshua Peraza committed May 16, 2023
    Configuration menu
    Copy the full SHA
    3307c7c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Fix broken doc links

    Links to/from run_with_crashpad.md were broken due to a location change.
    
    Change-Id: I5bb6d1f945bd22d9e55affa60909aa3b58e532bc
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4544457
    Reviewed-by: Mark Mentovai <[email protected]>
    thomasgales authored and markmentovai committed May 17, 2023
    Configuration menu
    Copy the full SHA
    8525d53 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Configuration menu
    Copy the full SHA
    e67d687 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. Configuration menu
    Copy the full SHA
    dc77935 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Configuration menu
    Copy the full SHA
    96b7d5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3bc2282 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af58387 View commit details
    Browse the repository at this point in the history
  4. Make the ios-build happy about the proxy-settings.

    We don't support crashpad on ios.
    supervacuus committed May 22, 2023
    Configuration menu
    Copy the full SHA
    e29852c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    98412e9 View commit details
    Browse the repository at this point in the history
  6. ios: Add fallbacks to try_free_default and claimed_address in forbidd…

    …en allocators.
    
    This test only change should improve flake on iOS XCUITests. try_free_default can receive a pointer which doesn't belong to the
    allocator and claimed_address may not be implemented in specified zone.
    Add fallbacks for both.
    
    This logic is identical to the Chromium equivalent shim in
    base/allocator/partition_allocator/shim/allocator_shim_default_dispatch_to_mac_zoned_malloc.cc
    
    Bug:b/270620301
    Change-Id: I4a788d4fbc7b324caff18e41618a5f999b4b8d4e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4549684
    Reviewed-by: Mark Mentovai <[email protected]>
    Justin Cohen authored and Justin Cohen committed May 22, 2023
    Configuration menu
    Copy the full SHA
    1103dfc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fb12516 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f72392e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7041349 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Update mini_chromium

    Update to a version of mini_chromium that supports RISCV64.
    
    Bug: fuchsia:127655
    
    Tested: `python build/run_tests.py` for Linux target
    Change-Id: I872e5e79933eb8f9b9fe7f4ae243ee9bb04c14b0
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4563254
    Reviewed-by: Mark Mentovai <[email protected]>
    thomasgales authored and markmentovai committed May 24, 2023
    Configuration menu
    Copy the full SHA
    402d431 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. Merge pull request #86 from supervacuus/feat/handler_http_proxy_support

    feat: handler http-proxy support
    supervacuus authored May 27, 2023
    Configuration menu
    Copy the full SHA
    3cdef1c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #85 from xyz1001/getsentry

    Fix compiler error with msvc on non-unicode system
    supervacuus authored May 27, 2023
    Configuration menu
    Copy the full SHA
    514169d View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. ios: More deflaking handler forbidden allocators.

    - Stop overloading introspect (or implement this in the future)
    - Store each overridden allocation zone and correctly direct calls to
      the requested zone.
    
    Change-Id: I7294e476bb683149acc61419b095ec0e1098781b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4574037
    Reviewed-by: Joshua Peraza <[email protected]>
    Justin Cohen authored and Justin Cohen committed May 31, 2023
    Configuration menu
    Copy the full SHA
    1fdbd37 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Remove Mac OS X Server support

    Mac OS X Server has been discontinued as a separate operating system
    flavor since 10.6. Current minimal requirements for both Crashpad and
    Chromium are above that.
    
    Change-Id: Ia9063be2e55a48e45d9f9974ac2e51bac004f37d
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4584570
    Reviewed-by: Mark Mentovai <[email protected]>
    eran-rom authored and markmentovai committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    788b72f View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. [fuchsia] Add fp registers to x86 context

    This lays groundwork for floating point registers to also be included in
    RISC-V CPU context.
    
    Bug: fuchsia:5496
    
    Tested: `fx test crashpad`
    Change-Id: I6230f146f955ac27f053f670f7f45dfff3560d02
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4594586
    Reviewed-by: Mark Mentovai <[email protected]>
    thomasgales authored and markmentovai committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    25f724d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. [snapshot] Suppress function type mismatch UB

    UBSan is detecting a function type mismatch in this test. This is
    because TestModule_GetCrashpadInfo returns a TestCrashpadInfo* but the
    function expectes to return a CrashpadInfo*. Structurally, the
    TestCrashpadInfo struct is meant to replicate a CrashpadInfo
    byte-for-byte, but there's no relationship between the types.
    
    Bug: fxbug.dev/128274
    Change-Id: I7b02ca802e55274116d46513b3aa6dc998f6d292
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4599482
    Reviewed-by: Mark Mentovai <[email protected]>
    PiJoules authored and markmentovai committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    656fc62 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. feat: add response body to error log...

    ...in case the response status is not 200. This is
    important, because if the crashpad-handler receives
    an 400 (Bad Request) for whichever reason, it will
    detail why in the response-body.
    
    This helps customers and us to figure out why the
    minidump endpoint negates requests from the
    crashpad-handler in case this happens.
    supervacuus committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    825cec1 View commit details
    Browse the repository at this point in the history
  2. [riscv] Add RISC-V Linux support

    Only RV64GC is supported.
    
    Bug: fuchsia:127655
    
    Tested: `python build/run_tests.py` on RISC-V emulator
    Tested: Created minidump via self-induced crash on RISC-V emulator,
    ran through Breakpad stackwalker
    
    Change-Id: I713797cd623b0a758269048e01696cbce502ca6c
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4581050
    Reviewed-by: Joshua Peraza <[email protected]>
    thomasgales authored and Joshua Peraza committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4f5dd67 View commit details
    Browse the repository at this point in the history
  3. [riscv][fuchsia] Add RISC-V Fuchsia support

    Only RV64GC is supported.
    
    RISC-V Fuchsia is not able to serve packages yet so unit testing is not
    possible.
    
    Bug: fuchsia:127655
    
    Tested: `crasher` with crashpad added to crashsvc, ran minidump through
    Breakpad stackwalker
    
    Change-Id: I1b6d79128759281aee348e333ea15434ab397001
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4602412
    Reviewed-by: Mark Mentovai <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    thomasgales authored and Joshua Peraza committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    2cf938a View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. [fuchsia] Don't build crashpad_database_util

    Fuchsia does its own storage and upload now, so crashpad_database_util
    is no longer relevant to Fuchsia.
    
    Tested: Compiled for and in Fuchsia. Verified crashpad_database_util
    artifacts no longer produced.
    Change-Id: Ie20bb9b308b77bdd39924f5fe70f182c5c2a0782
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4610969
    Reviewed-by: Joshua Peraza <[email protected]>
    thomasgales authored and Joshua Peraza committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    9464ef5 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. [fuchsia] Remove/replace outdated bug references

    Fuchsia migrated issue tracking to fxbug.dev. It appears that DX-1193
    did not get migrated.
    
    Fixed: 121707
    Change-Id: I4a7fdf00aed223fedd8b66df87647a29139782a1
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4616910
    Reviewed-by: Joshua Peraza <[email protected]>
    thomasgales authored and Joshua Peraza committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    a540e58 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Merge pull request #87 from getsentry/feat/crashpad_curl_response_bod…

    …y_log
    
    crashpad_handler: add response body to error log if status is not OK
    supervacuus authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    432ff49 View commit details
    Browse the repository at this point in the history
  2. [fuchsia][arm64] Don't query for fp registers

    Fuchsia devices are failing to read floating point context for ARM
    because floating point registers are in the vector context for ARM.
    
    This CL prevents warning logs from being emitted in this situation.
    
    Fixed: fuchsia:129171
    
    Tested: `fx shell crasher` @ 659207de7293cb30
    Change-Id: I1d8d928da122aeb1bc4ac66b789cb638969d0fdf
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4617960
    Reviewed-by: Joshua Peraza <[email protected]>
    thomasgales authored and Joshua Peraza committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    dcdccf5 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Disable fastfail end_to_end tests on Windows

    Something in how python is launching these tests changed and
    means that although fastfails in fastfail_test_program launch
    WerFault it is not looking for or finding the registered
    module, so crashpad_wer.dll isn't being loaded, so no
    crashes are there to be analyzed.
    
    Run individually the test programs do produce a crash,
    and Chrome continues to catch fast fails.
    
    Bug: crashpad:458
    Change-Id: I52a6aa7aefb02d393c93c2c43ec67fc92b2bd0b0
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4637536
    Commit-Queue: Alex Gough <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    quidity authored and Crashpad LUCI CQ committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    7e5b8ab View commit details
    Browse the repository at this point in the history
  2. SetErrorMode() in fastfail tests

    Some versions of python call SetErrorMode which disables
    WerFault handling for the fastfail test programs. We can
    set this to a useful value, allowing these tests to run
    again locally.
    
    This does not enable the tests on the bots as they continue
    to fail.
    
    Bug: crashpad:458
    Change-Id: Ibdd2f92ed872bd76490db32dccb2257dd91f8280
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4641231
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Alex Gough <[email protected]>
    quidity authored and Crashpad LUCI CQ committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    bc1e904 View commit details
    Browse the repository at this point in the history
  3. Catch heap corruption failures on Windows

    Windows claims that heap corruption crashes are passed
    to Windows Error Reporting but they are not, they are
    swallowed and the process is simply terminated. WerFault.exe
    does not run.
    
    We can however intercept these crashes using a vectored
    exception handler which forwards STATUS_HEAP_CORRUPTION
    to the normal crash handler.
    
    Adds an end-to-end test.
    
    Bug: 2515
    Change-Id: I2e1361dacef6fd03ea0f00327fee0b05a0c4899e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4637533
    Commit-Queue: Alex Gough <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    quidity authored and Crashpad LUCI CQ committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a5e1796 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. [Fuchsia] Replace checking out gn SDK with core

    The gen_build_defs.py file is lightly modified from the original one in
    https://source.chromium.org/chromium/chromium/src/+/main:build/fuchsia/gen_build_defs.py to accommodate for the fact that the SDK gets
    downloaded into a different folder in crashpad
    
    Bug: chromium:1432399
    Change-Id: I2c5a5337220b6aca138ca6eb1c37895ca32e72cd
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4600615
    Commit-Queue: Chong Gu <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    Chong Gu authored and Crashpad LUCI CQ committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    87e1883 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Convert Crashpad to use ARC

    See
    https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md
    for information about this conversion.
    
    Bug: chromium:1280726
    Change-Id: I9ed10e9a255eb6b13035b05bcc587c4b6cb7b78e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4651106
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    9e37dc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Disable PtraceBroker.SameBitness

    Bug: chromium:1459865
    Change-Id: I28d5caa739c5b59f4af1f062616443aa16fadfa1
    Fixed: chromium:1459862
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4663174
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    00ce1f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. [inspect] Route InspectSink in crashpad

    Bug: 93344
    Change-Id: Id794e3c79983b4c2352842edfe73a81ad3958b6e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4676565
    Commit-Queue: Clayton McCray <[email protected]>
    Commit-Queue: Francois Rousseau <[email protected]>
    Reviewed-by: Francois Rousseau <[email protected]>
    Clayton McCray authored and Crashpad LUCI CQ committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    dcba40c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Remove redundant ARC configuration in Crashpad

    ARC is now enabled by default in Chromium, so enabling it explicitly
    in Crashpad is redundant.
    
    Bug: chromium:733237
    Change-Id: I59dd863c0f8e7e16e88b6daccc5f900829c0cec5
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4721646
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    Commit-Queue: Avi Drissman <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3df478b View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. [fuchsia] Don't build CaptureContext

    CaptureContext isn't actually used on Fuchsia and there is a desire to
    remove `ucontext_t` from Fuchsia as it isn't a real concept on Fuchsia
    and was only added as a placeholder. Moreover, `ucontext_t` won't ever
    be added to Fuchsia for RISC-V.
    
    Bug: fuchsia:123052
    Fixed: fuchsia:131112
    Fixed: fuchsia:127655
    Tested: `fx test crashpad` on core.x64 emulator
    Tested: `fx test crashpad` on ARM64 device
    Tested: `fx shell crasher` @ 16b19a9891978487 on ARM64 device, ran
    through Breakpad stackwalker locally as well
    Tested: `fx build crashpad_tests` for minimal.riscv64
    Change-Id: I4695054426df78a9deff8c9ea9c478b5bf9701b1
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4717085
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Thomas Gales <[email protected]>
    thomasgales authored and Crashpad LUCI CQ committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    8dcf2b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. [fuchsia][mac] Fix build errors

    A recent CL [1] broke Fuchsia's Crashpad roller due to duplicate build
    argument declarations. This CL ensures that sysroot.gni is only imported once.
    
    [1] https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/4651973
    
    Fixed: fuchsia:131454
    Change-Id: Idcf6ac65cdffee2c9a9551559a8aab0063044428
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4743381
    Reviewed-by: Joshua Peraza <[email protected]>
    Commit-Queue: Thomas Gales <[email protected]>
    thomasgales authored and Crashpad LUCI CQ committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ca6d64d View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Add SetLastChanceExceptionHandler to implement permissive MTE mode

    SetLastChanceExceptionHandler sets a callback to be called after a
    crash has been reported. Returning true from this callback will
    not reraise the signal so the execution can continue. This will be
    used to implement permissive MTE mode, which will continue execution
    after a MTE crash.
    
    Bug: chromium:1467915
    Change-Id: I93a28ceea921fe977805482cf47c07643ca6133c
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4707688
    Reviewed-by: Robert Sesek <[email protected]>
    Commit-Queue: Keishi Hattori <[email protected]>
    Keishi Hattori authored and Crashpad LUCI CQ committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b1e66e3 View commit details
    Browse the repository at this point in the history
  2. Revert "Add SetLastChanceExceptionHandler to implement permissive MTE…

    … mode"
    
    This reverts commit b1e66e3.
    
    Reason for revert: test was flaky on Android bot
    
    Original change's description:
    > Add SetLastChanceExceptionHandler to implement permissive MTE mode
    >
    > SetLastChanceExceptionHandler sets a callback to be called after a
    > crash has been reported. Returning true from this callback will
    > not reraise the signal so the execution can continue. This will be
    > used to implement permissive MTE mode, which will continue execution
    > after a MTE crash.
    >
    > Bug: chromium:1467915
    > Change-Id: I93a28ceea921fe977805482cf47c07643ca6133c
    > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4707688
    > Reviewed-by: Robert Sesek <[email protected]>
    > Commit-Queue: Keishi Hattori <[email protected]>
    
    Bug: chromium:1467915
    Change-Id: Id815a780b576088974101117a4587adec64cfe8c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750459
    Commit-Queue: Keishi Hattori <[email protected]>
    Bot-Commit: Rubber Stamper <[email protected]>
    Keishi Hattori authored and Crashpad LUCI CQ committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ce7f0f1 View commit details
    Browse the repository at this point in the history
  3. Remove ARC boilerplate in Crashpad

    ARC is now enabled by default, so there’s no need to enforce it
    against files being put into non-ARC targets.
    
    Bug: chromium:1468376
    Change-Id: I58bbb4d1736293a6e9977954ce932dcfe2bafa54
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750419
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    617429d View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ e009af846..d1b…

    …aeddcb (3 commits)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/e009af846ef4..d1baeddcb8de
    
    $ git log e009af846..d1baeddcb --date=short --no-merges --format='%ad %ae %s'
    2023-08-03 pkasting Reorder string_util.h platform-specific #includes to match Chromium.
    2023-08-04 rahul.yadav Add base/types/cxx23_to_underlying.h to mini_chromium base
    2023-08-03 pkasting Add base::IsAscii(Digit,Whitespace) to mini_chromium.
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Change-Id: I93ba6ef4eba235840e18d0981aaaa926da26159a
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750022
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Kasting <[email protected]>
    pkasting authored and Crashpad LUCI CQ committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8132af7 View commit details
    Browse the repository at this point in the history
  2. Ban [w]ctype.h: crashpad

    Bug: chromium:1361094
    Change-Id: Ia5dacb9038cd74b5d490282a8070fb4579ebe3ae
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750179
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Kasting <[email protected]>
    pkasting authored and Crashpad LUCI CQ committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    419f995 View commit details
    Browse the repository at this point in the history
  3. Revert "[fuchsia][mac] Fix build errors"

    This reverts commit ca6d64d.
    
    Reason for revert: The changes did not actually fix the problem once combined with the latest changes from mini_chromium.
    
    Original change's description:
    > [fuchsia][mac] Fix build errors
    >
    > A recent CL [1] broke Fuchsia's Crashpad roller due to duplicate build
    > argument declarations. This CL ensures that sysroot.gni is only imported once.
    >
    > [1] https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/4651973
    >
    > Fixed: fuchsia:131454
    > Change-Id: Idcf6ac65cdffee2c9a9551559a8aab0063044428
    > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4743381
    > Reviewed-by: Joshua Peraza <[email protected]>
    > Commit-Queue: Thomas Gales <[email protected]>
    
    Change-Id: Id3dc42484fbd87e242756c8d2889d2e404370ac7
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4753637
    Commit-Queue: Thomas Gales <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    thomasgales authored and Crashpad LUCI CQ committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    343aa69 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Add support for linux-arm64

    To support linux-arm64 build hosts, use an appropraite build of gn on
    those systems.
    
    To support linux-arm64 targets, this also updates mini_chromium to
    2035d204bd0f812ac95a1ed72038e6bdbcfce4a2:
    
    2035d204bd0f Add support for linux-arm64
    
    Change-Id: I04139d9136d36fcb0a15aee2ce0694909d44ae95
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4760265
    Reviewed-by: Joshua Peraza <[email protected]>
    markmentovai committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    77c1ad2 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ 2035d204b..a72…

    …2d31ef (1 commit)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/2035d204bd0f..a722d31ef524
    
    $ git log 2035d204b..a722d31ef --date=short --no-merges --format='%ad %ae %s'
    2023-08-07 tgales [fuchsia][mac] Fix build errors
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Fixed: fuchsia:131454
    Change-Id: I77d9291cb9cd9cdf967761567e27ae9b0b32b98b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4761366
    Reviewed-by: Joshua Peraza <[email protected]>
    Commit-Queue: Thomas Gales <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    thomasgales authored and Crashpad LUCI CQ committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    3f3b7a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Update comment for new file location

    https://crrev.com/c/4781926 moves PA files to new locations. This
    updates the filename reference.
    
    Bug: chromium:1444927
    Change-Id: I7947711055eb444ab5bc28d4e3c6ca2c39a17e04
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4784548
    Commit-Queue: Avi Drissman <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    43d04a8 View commit details
    Browse the repository at this point in the history
  2. Adjust to movement of base/ files to base/apple

    This CL rolls mini_chromium to pick up the move of a bunch of files
    to base/apple, and makes changes to adjust.
    
    Bug: chromium:1444927
    Change-Id: Ib692e2a1628e2c0c8228795eaecdb7f35b1c09fa
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4786387
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Avi Drissman <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    6a9e2e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Roll mini_chromium, adjust to more files in base/apple

    This rolls mini_chromium to the version that has more files in
    base/apple, and adjusts the code to match.
    
    Bug: chromium:1444927
    Change-Id: I9642698c8c16151bd0aaca7b46745a59d6e5e6d3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4791121
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Avi Drissman <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    13e3acc View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. [fuchsia] Move //zircon/public/lib/zx to //zircon/system/ulib/zx

    Bug: fuchsia:70426
    Change-Id: I346b0d4c1bd411ef106fdc36ca4d846d875fceb9
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4753382
    Commit-Queue: Mark Mentovai <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    digit-android authored and Crashpad LUCI CQ committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    50ce155 View commit details
    Browse the repository at this point in the history
  2. Roll mini_chromium putting /base/apple files into base::apple::

    Bug: chromium:1474628
    Change-Id: Ief0efef22759b935045bf0216a313c2de8025403
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4799234
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Avi Drissman <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a736f7d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. tests: stop using legacy gtest APIs

    These are being removed from gtest, so stop using them.
    
    Bug: chromium:1474588
    Change-Id: I0d42da9f14dad5c5dc17d980146cb289d444dbda
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4803329
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mike Frysinger <[email protected]>
    vapier authored and Crashpad LUCI CQ committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    52c427a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ 0c540fd54..10f…

    …39a976 (1 commit)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/0c540fd5462a..10f39a97650a
    
    $ git log 0c540fd54..10f39a976 --date=short --no-merges --format='%ad %ae %s'
    2023-08-09 tgales [riscv][android] Add Android RISC-V support
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Fixed: fuchsia:128936
    Change-Id: Iee194c24b1dd4418e0f882c7e8c96e2c85eaa617
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4824417
    Reviewed-by: Joshua Peraza <[email protected]>
    Commit-Queue: Thomas Gales <[email protected]>
    thomasgales authored and Crashpad LUCI CQ committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    ea0496c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Reland "Add SetLastChanceExceptionHandler to implement permissive MTE…

    … mode"
    
    This is a reland of commit b1e66e3
    
    Original change's description:
    > Add SetLastChanceExceptionHandler to implement permissive MTE mode
    >
    > SetLastChanceExceptionHandler sets a callback to be called after a
    > crash has been reported. Returning true from this callback will
    > not reraise the signal so the execution can continue. This will be
    > used to implement permissive MTE mode, which will continue execution
    > after a MTE crash.
    >
    > Bug: chromium:1467915
    > Change-Id: I93a28ceea921fe977805482cf47c07643ca6133c
    > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4707688
    > Reviewed-by: Robert Sesek <[email protected]>
    > Commit-Queue: Keishi Hattori <[email protected]>
    
    Bug: chromium:1467915
    Change-Id: Ibdc18084deb08bccf3c74f688b7d48ff24fe81f9
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4756235
    Reviewed-by: Robert Sesek <[email protected]>
    Commit-Queue: Keishi Hattori <[email protected]>
    Keishi Hattori authored and Crashpad LUCI CQ committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a7cfe95 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. [ssci] Added Shipped field to READMEs

    This CL adds the Shipped field in READMEs. See the LSC
    doc at go/lsc-chrome-metadata.
    
    Bug: b:285450740
    Change-Id: I3dcd5e027f06982f4c2dd98136d3a6d7f6228b4e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4666416
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    anneredulla authored and Crashpad LUCI CQ committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d25c332 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. mac: Fix build with deployment target ≥ 11

    This fixes the following warning during compilation:
    
    > process_reader_mac_test.cc:670:7: warning: address of function
    > '_dyld_shared_cache_contains_path' will always evaluate to 'true'
    > [-Wpointer-bool-conversion]
    
    while still retaining compatibility with pre-macOS 11 runtimes when
    built with a suitable deployment target.
    
    Bug: 461
    Change-Id: I61a360e8e02ceb7209c887819a4916a68384b89d
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4873433
    Reviewed-by: Joshua Peraza <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    markmentovai authored and Crashpad LUCI CQ committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8da335f View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    b606087 View commit details
    Browse the repository at this point in the history
  2. Update mini_chromium

    supervacuus committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6366a47 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a9f5249 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e7a4f6 View commit details
    Browse the repository at this point in the history
  5. Deregister vectored exception handler on client destruction

    Some users of crashpad load and unload the dll that hosts
    crashpad code. crashpad registers a vectored exception handler
    to help collect heap corruption crashes. If the dll is
    unloaded this handler might still be called.
    
    This CL adds a scoped handler for such registrations and
    uses it on Windows crashpad client. To allow this to
    be stored, RegisterHandler() on the client needs to move
    onto the client object from being a helper function.
    
    Bug: crashpad:462
    Change-Id: I5d77c056e2a9a61ddcfa9d0186ab4bfd85a19bff
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4898263
    Reviewed-by: Ben Hamilton <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    Commit-Queue: Alex Gough <[email protected]>
    quidity authored and Crashpad LUCI CQ committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ac0c27a View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Configuration menu
    Copy the full SHA
    695d159 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bd37fea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b601eb4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3299fb2 View commit details
    Browse the repository at this point in the history
  5. Add support for matching with key allowlist

    WebView makes use of this allowlist. We are hoping to
    include switches and features in our crash keys as users
    can enable these with an easily available developer UI.
    
    These crash keys follow a pattern of "switch-<index>" so
    it is impractical to indefinitely add a larger list of switch
    keys. Adding this matcher lets us rather add "switch-*".
    
    Bug: 1484644
    Change-Id: I667cef70cce1efb0710b4a2f009d8d80a1eeae5a
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4894239
    Commit-Queue: Rupert Wiser <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    Rupert Ben Wiser authored and Crashpad LUCI CQ committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7f6d9e9 View commit details
    Browse the repository at this point in the history
  6. Update chromium_mini dependency

    We had an issue that was causing breackages with Fuchsia builders. We
    needed to copy over additional code to mini_chromium. Making sure this
    relies on the improved version as well.
    
    Bug: 1484644
    Change-Id: I0250a44cb29c758d7865cc6222d32a69048c9157
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4905890
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    Rupert Ben Wiser authored and Crashpad LUCI CQ committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    485cfaf View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Enable ARC in CMake build

    supervacuus committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    dbe03a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Update lss to 9719c1e

    supervacuus committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    f37da0f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #88 from getsentry/meta/update

    meta: update 2023-09-28
    supervacuus authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    12e1dae View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. ios: Fix Chromium bundle id for xcuitest.

    This is needed in Chromium for enabling iOS PartitionAlloc
    
    Rolls mini_chromium to support overriding the BundleIdentifier.
    
    Bug: 1489308
    Change-Id: I314958182f35edba3300e545b2877d288b43ccb9
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4911575
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    b90db3e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Pull latest toolchain

    The previous CIPD location was stale and the packages there are no
    longer updated. Compiling for Fuchsia using the latest toolchain
    revealed that zlib needed to be updated as well to resolve errors
    thrown by -Wstrict-prototypes.
    
    Newer versions of zlib fail to compile for Fuchsia without the addition
    of -Wno-sign-compare, recommended for this situation by the Fuchsia
    toolchain team.
    
    Bug: fuchsia:128938
    Bug: fuchsia:128939
    
    Change-Id: Iccf6dcb1aef1e1811f458fd18a2f04e7b044a918
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4893089
    Commit-Queue: Thomas Gales <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    thomasgales authored and Crashpad LUCI CQ committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a1b467a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Mac: update ProcessReaderMac and tests for macOS 14

    dyld in macOS 14 has two changes that impact how we read in modules:
    - Timestamp is always empty
    - The executable appears *last* rather than first in the
    dyld_all_image_infos array (see comment for details)
    
    This change:
    - Removes all timestamp checks in the tests
    - Removes 10.6 era code that worked around a different "executable in
    the wrong place" issue. Replaces this with a new branch that checks
    if the executable is in the last position, and rotates it to the
    front if so. This is necessary instead of just swapping (as in the 10.6
    code)  so that it can match the order returned by the `dyld_get_image...` family.
    
    Bug: chromium:1452203
    Change-Id: Iac9b29a0d9b9461b0ef386c9541661171ef9fd11
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4917145
    Commit-Queue: Leonard Grey <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    speednoisemovement authored and Crashpad LUCI CQ committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0fc1b6a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    45836a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Merge pull request #89 from getsentry/fix/fatal_dcheck_in_minidump_co…

    …ntext_writer
    
    fix: replace DCHECK with LOG in minimdump_context_writer
    supervacuus authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    3182e3b View commit details
    Browse the repository at this point in the history
  2. Stop registering Windows VEH in ASAN builds.

    ASAN injects a bad de-reference in HandleHeapCorruption() that causes it to be recursively invoked.
    
    Bug: crashpad:464
    Change-Id: I5e8db5555462166b963e0e43c6eb8ac0b327219e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4935953
    Reviewed-by: Alex Gough <[email protected]>
    Commit-Queue: Rich Mckeever <[email protected]>
    richmckeever authored and Crashpad LUCI CQ committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    f145b54 View commit details
    Browse the repository at this point in the history
  3. Mac: don't consider module order in process reader tests

    This is a follow-up to 0fc1b6a.
    
    The change in macOS 14's dyld to insert new modules in the front of
    `dyld_all_image_infos` means that if any images are loaded after the
    executable and its direct dependencies, it's no longer possible to
    rotate the list to match the order used by the `dyld_get_image...`
    APIs.
    
    This forces us to dispense with checking the order at all except to
    ensure that the executable is first, and dyld itself is last.
    
    Additionally fixes an unreachable return introduced in
    0fc1b6a.
    
    Bug: chromium:1452203
    Change-Id: If0b09b9110d8f60d29cca79ea6a59050b0293c5e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4935952
    Commit-Queue: Leonard Grey <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    speednoisemovement authored and Crashpad LUCI CQ committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    2f6cffa View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Windows: don't compile HandleHeapCorruption on ASAN

    f145b54 put the only reference to this
    in a non-ASAN block, so we're hitting an unused function warning rolling
    into Chromium
    
    Bug: crashpad:464
    Change-Id: I225debd48a255aa5214e02a6821dcd72c618f141
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4939552
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Leonard Grey <[email protected]>
    speednoisemovement authored and Crashpad LUCI CQ committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    63ec948 View commit details
    Browse the repository at this point in the history
  2. [ios] Remove ios_use_shared_bundle_id_for_test_apps gn variable

    The variable was to true in https://crrev.com/c/3308823 and is
    never overridden. Remove it as it simplify the logic of the
    test targets (and remove code duplication).
    
      This is a followup to https://crrev.com/c/4935576 which make
      the corresponding change in the Chromium repository.
    
    Bug: 1250788
    Change-Id: Ide05fa3bf4177b5761ef0ad5c6edf9baf181b28c
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4943570
    Commit-Queue: Sylvain Defresne <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    sdefresne authored and Crashpad LUCI CQ committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7c89d50 View commit details
    Browse the repository at this point in the history
  3. Use format macros for int64_t instead of hardcoding the format.

    Bug: 1371963
    Change-Id: I7fa4557472684cdd2b8e0cc977230941f26f1eaa
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4943901
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Kasting <[email protected]>
    pkasting authored and Crashpad LUCI CQ committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    aef7504 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ 276f2ac53..42f…

    …1fddfe (1 commit)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/276f2ac531cd..42f1fddfec57
    
    $ git log 276f2ac53..42f1fddfe --date=short --no-merges --format='%ad %ae %s'
    2023-10-16 pkasting Use POSIX format specifiers on Windows.
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Bug: 1371963
    Change-Id: I7210b416b5e498b9888d1c942084c07ef177b667
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4944315
    Commit-Queue: Peter Kasting <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    pkasting authored and Crashpad LUCI CQ committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ce4e3d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Do IWYU for check_op.h

    Include check_op.h directly, instead of relying on the transitive
    include from logging.h. This transitive include does not exist in
    Chromium's //base.
    
    Change-Id: I15962a9cdc26ac206032157b8d2659cf263ad695
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4950200
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Lei Zhang <[email protected]>
    leizleiz authored and Crashpad LUCI CQ committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    c63c073 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ 42f1fddfe..bc8…

    …dca83b (3 commits)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/42f1fddfec57..bc8dca83bd2f
    
    $ git log 42f1fddfe..bc8dca83b --date=short --no-merges --format='%ad %ae %s'
    2023-10-18 pkasting Add iter_reference_t to template_util.h.
    2023-10-18 thestig Remove check_op.h from base/logging.h
    2023-10-17 pkasting Add base::StrCat().
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Bug: 1371963
    Change-Id: I19a74661930c733814403c9813fe544fe0540b1f
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4953853
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Kasting <[email protected]>
    pkasting authored and Crashpad LUCI CQ committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b6d3cdc View commit details
    Browse the repository at this point in the history
  2. Eliminate call to StringPrintf() with non-constexpr format string.

    Bug: 1371963
    Change-Id: Ic3cc2010e48c399de8d19b94c3b515b53e2d18a3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4953795
    Commit-Queue: Peter Kasting <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    pkasting authored and Crashpad LUCI CQ committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    376e8c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Add an option to start a Windows client with global hooks disabled.

    Change-Id: I645d6136788ca4ccebfc73005c8c2455dc4b2cee
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4949671
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Rich Mckeever <[email protected]>
    richmckeever authored and Crashpad LUCI CQ committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e17518a View commit details
    Browse the repository at this point in the history
  2. Update mini_chromium & use its new support for wide streaming in file…

    …_path
    
    Fixes a pending issue when we eventually move to C++20.
    
    Original author: Dean Sturtevant
    
    Change-Id: I7bb0648c73df6b6a28a3a4debdb4524d3cd27b38
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4979733
    Reviewed-by: Justin Cohen <[email protected]>
    Commit-Queue: Eric Astor <[email protected]>
    ericastor authored and Crashpad LUCI CQ committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    59fc31c View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ 707c87bd2..98b…

    …bdbe49 (1 commit) + changes
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/707c87bd258d..98bbdbe49f4a
    
    $ git log 707c87bd2..98bbdbe49 --date=short --no-merges --format='%ad %ae %s'
    2023-10-27 avi Update ScopedTypeRef
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    ---
    
    In addition, change implicit unwrapping of ScopedCFTypeRef to be
    explicit.
    
    Bug: chromium:1495438, chromium:1495439
    Change-Id: I47dd12f94f71caaad74cf23be9da9d03a59772db
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4984741
    Commit-Queue: Avi Drissman <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    188ad79 View commit details
    Browse the repository at this point in the history
  2. Revert "Add an option to start a Windows client with global hooks dis…

    …abled."
    
    This reverts commit e17518a.
    
    Reason for revert:
    
    When trying to roll Crashpad into Chromium, all the new tests in
    this CL fail; https://crrev.com/c/4984643?checksRunsSelected=win-rel&tab=checks
    
    Original change's description:
    > Add an option to start a Windows client with global hooks disabled.
    >
    > Change-Id: I645d6136788ca4ccebfc73005c8c2455dc4b2cee
    > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4949671
    > Reviewed-by: Mark Mentovai <[email protected]>
    > Commit-Queue: Rich Mckeever <[email protected]>
    
    Change-Id: I3a41238cf0960899fac19d1e6d0ed0e527dfe13f
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4985124
    Reviewed-by: Mark Mentovai <[email protected]>
    Bot-Commit: Rubber Stamper <[email protected]>
    Commit-Queue: Avi Drissman <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    4a93d7f View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Fix crashpad tests under UBSan

    These are slightly frustrating. First, when a struct is packed, some of
    its fields may be underaligned. This is fine for direct access
    (foo.bar), but if one takes the address if the field, this creates an
    unaligned pointer. Dereferencing that pointer is then UB. (I'm not sure
    if creating that pointer is UB.)
    
    Crashpad seemingly doesn't do this, but it uses EXPECT_EQ from GTest.
    EXPECT_EQ seems to internally take pointers to its arguments. I'm
    guessing it binds them by const reference. This then trips UBSan. To
    avoid this, we can copy the value into a temporary before passing to
    EXPECT_EQ.
    
    Second, the test to divide by 0 to trigger SIGFPE is undefined behavior.
    The compiler is not actually obligated to trip SIGFPE. UBSan prints one
    of its errors instead. Instead, since this file is only built on POSIX
    anyway, use GCC inline assembly to do the division. That one is
    well-defined.
    
    Finally, casting a string to uint32_t* is undefined both by alignment
    and by strict aliasing (although Chromium doesn't enable the latter).
    Instead, type-punning should be done with memcpy.
    
    Bug: chromium:1394755
    Change-Id: I79108773a04ac26f5189e7b88a0acbf62eb4401d
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4985905
    Reviewed-by: Robert Sesek <[email protected]>
    Commit-Queue: David Benjamin <[email protected]>
    davidben authored and Crashpad LUCI CQ committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    41f6ad5 View commit details
    Browse the repository at this point in the history
  2. Fix UB when saving an StringAnnotation

    memcpy and memchr on NULL, 0 is UB due to a C language bug. Instead, use
    the C++ functions, which do not have this bug.
    
    Bug: chromium:1394755
    Change-Id: I82023aa038c53905f9867c635b26f3b26d9994f5
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4987148
    Commit-Queue: David Benjamin <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    davidben authored and Crashpad LUCI CQ committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    c5e2b03 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Provide a way to iterate over a const AnnotationList

    This CL implements a const iterator to allow for iteration over a const
    AnnotationList. This way, the annotation list can passed as a const
    reference in search only situations.
    
    Change-Id: I53bd7871f3d914e7e7e627b6b464aa7fa79597f4
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4984053
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Andre Kempe <[email protected]>
    andre-kempe-arm authored and Crashpad LUCI CQ committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c39206f View commit details
    Browse the repository at this point in the history
  2. ios: Fix leak in iOS NSException preprocessor.

    Call __cxa_free_exception after __cxa_allocate_exception usage.
    
    Change-Id: I0cd5043b945652e6ac28c3bf79486c071d3aa09e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4990028
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3ba2403 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Add missing base/check.h includes

    Do not rely on base/logging.h to provide it.
    
    Change-Id: I8b7d733bcf66abe9b46eabd3703b7ed549d02db7
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5007844
    Commit-Queue: Lei Zhang <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    leizleiz authored and Crashpad LUCI CQ committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    1675ce7 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ e508a6010..450…

    …b10118 (1 commit)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/e508a6010e25..450b101187b5
    
    $ git log e508a6010..450b10118 --date=short --no-merges --format='%ad %ae %s'
    2023-11-06 pkasting Rename WCHAR_T_IS_UTF* to WCHAR_T_IS_*BIT
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Change-Id: Id39911a5dbd1275199400848428ab024bb62cf2a
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5008818
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Kasting <[email protected]>
    pkasting authored and Crashpad LUCI CQ committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5739185 View commit details
    Browse the repository at this point in the history
  2. Replace base::WStringPiece with std::string_view

    Bug: chromium:691162
    Change-Id: I2d34bcfd3b97d59d1811183d62b893b875b08bb4
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5010942
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Lei Zhang <[email protected]>
    leizleiz authored and Crashpad LUCI CQ committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5613499 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. build: adjust for Windows ARM64

    Windows ARM64 uses a different ASM variant.  The assembly is already correct but the CMake setup for the variant was not.  This corrects that to enable building crashpad for Windows ARM64.  Beyond this change, an update to zlib is required.
    compnerd authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    079636a View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Configuration menu
    Copy the full SHA
    202f5cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de6d596 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c6f8325 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    277df3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fec839d View commit details
    Browse the repository at this point in the history
  3. Merge pull request #90 from compnerd/arm64-asm

    build: adjust for Windows ARM64
    supervacuus authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    abdc106 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #91 from getsentry/meta/update

    Meta: update 2023-11-24
    supervacuus authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e63d0c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. build: remove obsolete source file

    `simd_stub.c` was removed from the repository upstream. This updates the CMakeLists.txt so that it is possible to build for Windows ARM64.
    compnerd authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    eb9a5e2 View commit details
    Browse the repository at this point in the history
  2. build: adjust process name matching

    The ARM64 build should use the ARM64 branch.  The normal spelling for the CMAKE_SYSTEM_PROCESSOR is ARM64 when building with MSVC toolsets.  This allows building for Windows ARM64 with MSBuild + CMake.
    compnerd authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e8c474a View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Merge pull request #92 from compnerd/compnerd/zlib-update

    build: remove obsolete source file
    supervacuus authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b5ef60a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #93 from compnerd/processor

    build: adjust process name matching
    supervacuus authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    40875ed View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Use googletest flag macros to access googletest flags.

    The implementation details of flags can change; fixing this proactively
    makes it easier to roll googletest in chromium.
    
    Bug: chromium:1409870
    Change-Id: Ib27a922a5b3147386a36f98b42e60950e2215190
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5081703
    Commit-Queue: Daniel Cheng <[email protected]>
    Reviewed-by: Robert Sesek <[email protected]>
    zetafunction authored and Crashpad LUCI CQ committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    5fc60ae View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Configuration menu
    Copy the full SHA
    89991e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Fix improper use of bit_cast

    bit_cast should never be used on pointers, as it doesn't avoid UB and
    can lose qualifiers.
    
    Fortunately, the only use of bit_cast on a pointer was to cast
    nullptr into a function pointer, and because nullptr will implicitly
    behave as any kind of pointer, that cast isn't needed.
    
    Bug: none
    Change-Id: I3ad79b36b7fb5ab53d4b4b6dfc82dea883ec8b53
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5106728
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Avi Drissman <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7049d96 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. [mac] mach_absolute_time() -> clock_gettime_nsec_np(CLOCK_UPTIME_RAW)

    https://developer.apple.com/documentation/kernel/1462446-mach_absolute_time
    
    > Prefer to use the equivalent clock_gettime_nsec_np(CLOCK_UPTIME_RAW) in nanoseconds.
    
    The two are equivalent:
    
    https://github.com/apple-oss-distributions/Libc/blob/c5a3293354e22262702a3add5b2dfc9bb0b93b85/gen/clock_gettime.c#L118
    
    Change-Id: I1c7a08d821d1840b74fc5eaa0e9ceca2ade5bbfc
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5085307
    Commit-Queue: Ben Hamilton <[email protected]>
    Reviewed-by: Justin Cohen <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    337b4f7 View commit details
    Browse the repository at this point in the history
  2. Qualify bit_cast with base::

    The real Chromium base/bit_cast.h is in the base namespace.
    mini_chromium's version was just changed to be in the base namespace
    as well. Roll to the latest mini_chromium and scope all calls to
    bit_cast.
    
    Bug: chromium:1506769
    Change-Id: I7b25ee512f67694ef6ed3d0250e4f6a6db151eb3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5116880
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Avi Drissman <[email protected]>
    Avi Drissman authored and Crashpad LUCI CQ committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9f896f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. [ios] Add arm64e support to in_process_intermediate_dump_handler

    Change-Id: Ifc373d313db71872cc0fd7706da2bdc07cf4ba1b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5126940
    Reviewed-by: Justin Cohen <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    3a20cc2 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. [build] Re-enable action tracing

    Avoid unconditionally running mig in incremental builds,
    and causing un-necessary re-build of downstream targets.
    
    Bug: b/42147841
    Bug: b/42084680
    Change-Id: I961189870aec8f0b1a1ced22105730218664e109
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5171755
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: David Fang <[email protected]>
    fangism authored and Crashpad LUCI CQ committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    2905784 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ ac3e73239..cc2…

    …ae8eb0 (1 commit)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/ac3e73239534..cc2ae8eb01d0
    
    $ git log ac3e73239..cc2ae8eb0 --date=short --no-merges --format='%ad %ae %s'
    2024-01-10 pbos Add Flush() method to LogMessage
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Bug: chromium:1409729
    Change-Id: I59b4c9fc9701f3a504b89f396de9da49b333712f
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5185844
    Commit-Queue: Peter Boström <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    pbos authored and Crashpad LUCI CQ committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    bbb721f View commit details
    Browse the repository at this point in the history
  2. Roll crashpad/third_party/mini_chromium/mini_chromium/ cc2ae8eb0..1e6…

    …4ecb51 (1 commit)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/cc2ae8eb01d0..1e64ecb51edf
    
    $ git log cc2ae8eb0..1e64ecb51 --date=short --no-merges --format='%ad %ae %s'
    2024-01-10 pbos Make ~LogMessage virtual
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Bug: chromium:1409729
    Change-Id: Ib0011b85c35c781ea35e0d399cccb81b54916ca4
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5186000
    Commit-Queue: Peter Boström <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    pbos authored and Crashpad LUCI CQ committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    65f2a2b View commit details
    Browse the repository at this point in the history
  3. Roll crashpad/third_party/mini_chromium/mini_chromium/ 1e64ecb51..c7f…

    …ccaa8e (1 commit)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/1e64ecb51edf..c7fccaa8ec14
    
    $ git log 1e64ecb51..c7fccaa8e --date=short --no-merges --format='%ad %ae %s'
    2024-01-10 pbos Implement base::ImmediateCrash()
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Bug: chromium:1409729
    Change-Id: Iaa4f4d81027cb0ddafe85bab8d186949eb7f852e
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5186004
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Boström <[email protected]>
    pbos authored and Crashpad LUCI CQ committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4426ed9 View commit details
    Browse the repository at this point in the history
  4. Roll crashpad/third_party/mini_chromium/mini_chromium/ c7fccaa8e..203…

    …a01130 (1 commit)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/c7fccaa8ec14..203a01130fac
    
    $ git log c7fccaa8e..203a01130 --date=short --no-merges --format='%ad %ae %s'
    2024-01-10 pbos Fix base::ImmediateCrash() IWYU
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Bug: chromium:1409729
    Change-Id: Ic9fee112a48b66c92b8446270280d5f2a3d0ef59
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5187485
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Boström <[email protected]>
    pbos authored and Crashpad LUCI CQ committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    d256de3 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Add [[noreturn]] version of NtstatusLogMessage

    This will be used by base/logging.h in chromium to make sure that
    LOG(FATAL) variants never return and are properly understood as
    [[noreturn]] by the compiler.
    
    Once that's landed in chromium it'll be up/downstreamed into
    mini_chromium as well.
    
    Bug: chromium:1409729
    Change-Id: I75340643fe075475f997bbc45250fa10df63c9fa
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5185996
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Boström <[email protected]>
    pbos authored and Crashpad LUCI CQ committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    98d0d86 View commit details
    Browse the repository at this point in the history
  2. ios: Add crashpad_uptime_ns crash key to iOS reports.

    This CL introduces a new crash key 'crashpad_uptime_ns' that records the
    number of nanoseconds between when Crashpad was initialized and when a
    snapshot is generated.
    
    Crashpad minidumps record the MDRawMiscInfo process_create_time using a
    sysctl(KERN_PROC).kp_proc.p_starttime. This time is used to display the
    'uptime' of a process.  However, iOS 15 and later has a feature that
    'prewarms' the app to reduce the amount of time the user waits before
    the app is usable. This mean crashes that may happen immediately on
    startup would appear to happen minutes or hours after process creation
    time.
    
    While initial implementations of prewarming would include some parts of
    main, since iOS16 prewarming is complete before main, and therefore
    before Crashpad is typically initialized.
    
    Bug: crashpad:472
    Change-Id: Iff960e37ae40121bd5927d319a2767d1cafce846
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5171091
    Reviewed-by: Ben Hamilton <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    30b2f4b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Remove should-be-dead code after PLOG(FATAL)

    This will trigger dead-code warnings in chromium once LOG(FATAL) is
    understood as [[noreturn]], which needs to be fixed in crashpad first.
    
    Bug: 1409729
    Change-Id: I75cb4d93e648ca9804f1299345e52bb3e2834cd9
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5193351
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Boström <[email protected]>
    pbos authored and Crashpad LUCI CQ committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    5183bef View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. doc: Upgrade the crashpad-home App Engine app to the go121 flex runtime

    Change-Id: I0a30b816e2550e7df6d7777c6d27e6104fc2f9fa
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5206711
    Reviewed-by: Robert Sesek <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    markmentovai authored and Crashpad LUCI CQ committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    305b648 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. ios: Allow missing exception thread id from thread list.

    It's expected that iOS intermediate dumps can be written with
    missing information, but it's better to try and report as much as
    possible rather than drop the incomplete minidump.
    
    Bug: b/284959148
    Change-Id: I04110b576a4ee552814234d559c9ba85db0382f0
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4582167
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    22c386d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Avoid assuming string_view iterators are char*

    This assumption is non-portable and prevents Chromium from using
    bounded iterators in libc++.
    
    Bug: chromium: 1519908
    Change-Id: Iafe6639ef3bc896d6fa4fb3ceb7ac0b546363017
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5237292
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: danakj <[email protected]>
    danakj authored and Crashpad LUCI CQ committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a02e493 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. [fxbug.dev] Migrate bug numbers

    This changes fxbug.dev/ URLs from Monorail bug numbers to the new
    Fuchsia Issue Tracker numbers.
    
    The migration to the new issue tracker was announced here:
    https://groups.google.com/a/fuchsia.dev/g/announce/c/GOYfJozEqmk/m/qsGsaJ7UAAAJ
    
    Bug: 298074672
    Change-Id: I5f4b7a26a3f41bf539fa79d15e1a108ea35a5b29
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5246697
    Commit-Queue: Mark Mentovai <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Mitchell Kember authored and Crashpad LUCI CQ committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    27b460c View commit details
    Browse the repository at this point in the history
  2. ios: Read dyld modules in reverse order.

    The change in macOS 14's dyld to insert new modules in the front of
    `dyld_all_image_infos` means that if the any images are loaded
    during an exception while iterating the modules list, the primary
    executable will be missed. Instead, read the modules in reverse
    order.
    
    
    Change-Id: I49f6468173f18ef4bd0f326c84e4b48cfc696cd3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5249275
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5d81482 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Add Update method to CrashpadInfo

    This change adds a method to update a CrashpadInfo stream.
    
    As part of this change, AddUserDataMinidumpStream() now returns a handle
    to the added stream. This handle can be passed to
    UpdateUserDataMinidumpStream() if a new version of the stream needs to
    be attached to the crash report.
    
    This method is needed for e.g., allowing Chrome's System Profile to
    update, as it contains some data that takes a while to collect.
    
    Bug: crashpad:474
    Change-Id: I19e935a6904d8843215582e5606b189479ee338b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5260024
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Jesse McKenna <[email protected]>
    jessemckenna authored and Crashpad LUCI CQ committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c576bf3 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Honor ios_is_app_extension chromium build flag

    If building for chromium, honor the ios_is_app_extension gn variable
    that is set per toolchain. When it is defined, the code is built for
    an application extension (i.e. -fapplication-extension is passed to
    the compiler).
    
    Use CRASHPAD_IS_IOS_APP_EXTENSION build guard to not compile code
    that use unavailable extension when ios_is_app_extension is set. If
    the variable is not set, then check at runtime whether the API can
    be used or not (if the crashpad client uses the same toolchain for
    the main application and its application extensions).
    
    This is required to pass -fapplication-extension to the compiler when
    building application extensions (which allow catching API that is not
    available to application extensions).
    
    Bug: 40120082
    Change-Id: I28d545fcfd0f8662430c40ff202b79b0c2b2ff8b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5286216
    Reviewed-by: Justin Cohen <[email protected]>
    Commit-Queue: Sylvain Defresne <[email protected]>
    sdefresne authored and Crashpad LUCI CQ committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5075fb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fix leaky CrashpadInfo test

    CrashpadInfo::AddUserDataMinidumpStream() and
    UpdateUserDataMinidumpStream() allocate memory for the newly added
    streams. This change makes the CrashpadInfo test free that allocated
    memory to prevent memory leaks from these tests.
    
    This is intended to fix the ASAN failures seen on crrev.com/c/5285881:
    https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_asan_rel_ng/1839072/overview
    
    Bug: crashpad:474
    Change-Id: I6e030291594d22e316942a58805a177ce448053b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5292137
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Jesse McKenna <[email protected]>
    jessemckenna authored and Crashpad LUCI CQ committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    940e8a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    58d7207 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. [Fuchsia] remove use of fuchsia mac sdk

    Bug: b/325495632
    Change-Id: I19df5b44b76efcdb050344e79bcc2dfd18d8e289
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5299466
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    zijiehe-google-com authored and Crashpad LUCI CQ committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    29ac83c View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Properly update iterator

    Bug: 325296797
    Change-Id: I39f76519c46804ad663172abf91ef582bde135e7
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5310754
    Commit-Queue: Joshua Peraza <[email protected]>
    Reviewed-by: Justin Cohen <[email protected]>
    Joshua Peraza authored and Crashpad LUCI CQ committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    37afd37 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Log argv[0] for failing spawns

    This adds argv[0] for PLOG(FATAL) calls following a failed posix_spawn
    or execve call to make logs more useful.
    
    Bug: chromium:324982367
    Change-Id: I179928ec9f791ce5b365b3444aa3bb667f4ec4b3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5315332
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Boström <[email protected]>
    pbos authored and Crashpad LUCI CQ committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    bc4fd34 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Increase kMaxNumberOfAnnotations

    Chrome on ChromeOS is starting to run into problems where there are more
    than 200 annotations, primarily because we use a lot of command-line
    switches (40 or more) and commandline-enabled-features as well, each of
    which takes up an annotation. It's still rare (100s a day) but will
    probably become worse over time as more CrashKey uses are added.
    
    Increase kMaxNumberOfAnnotations to 400.
    
    BUG=296821415
    
    Change-Id: Iba7049014ee3c5ae9c45c4022600eaba50acd403
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5354336
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Ian Barkley-Yeung <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    ianby authored and Crashpad LUCI CQ committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9c58b66 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. ios: Disable annotations tests on older simulators on macOS 14.3

    There appears to be a change in dyld in macOS 14.3 that iOS 17
    accounts for, but older simulators do not. This causes the main
    binary to be listed twice when iterating modules, breaking some
    tests.
    
    Bug: crbug.com/328282286
    
    Change-Id: I71909fbc13bee6de23b10ffd92a791067f8ea909
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5353754
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c4d4a4d View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Make AnnotationList's iterator compliant to input iterator

    This CL make the iterators implemented by AnnotationList compliant to
    the requirements imposed by the C++ standard on input iterators.
    
    Change-Id: I263c94a97f5bcd7edd5ef4d8b65fa28b11876974
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5093147
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    andre-kempe-arm authored and Crashpad LUCI CQ committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    dea283a View commit details
    Browse the repository at this point in the history
  2. Fix invalid check for valid key of Pointer Authentication

    Arm's Pointer Authentication uses two keys for signing pointers, A-key
    and B-key. Although by default Clang uses the A-key if PAC support is
    enabled at compile time, this behaviour might be overridden via compiler
    command line.
    
    This CL fixes the check for the B-key being enabled. The key that shall
    be used for Pointer Authentication is denoted by bits 0 (A-key) or
    1 (B-key) of __ARM_FEATURE_PAC_DEFAULT. Hence, the previous way of
    checking by using bits 0 and 2 does not correctly identify the B-key.
    
    Bug: 40608466
    Change-Id: Ib2f226baa12a7145fa0b6e486e49d36e6b0a3cd7
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5341090
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Mark Mentovai <[email protected]>
    andre-kempe-arm authored and Crashpad LUCI CQ committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6bf5e1b View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. ios: Update exception test for Chromium release builds.

    After https://crrev.com/c/5375084, Chromium __libcpp_verbose_abort is
    handled differently for official non-dcheck builds. This change fixes
    the test expectation for release non-official builds.
    
    Bug: 330168249
    Change-Id: Iceb6d327f9e93fd366cc07abe27eefd1adf06472
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5378380
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ccd2065 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    433ed68 View commit details
    Browse the repository at this point in the history
  2. ios: Capture signal exception context memory regions correctly.

    Previously, Crashpad would only capture iOS thread context memory regions by iterating the task_threads->thread_get_state's. For Mach
    exception this worked as intended.  However, for signal exceptions this
    missed the registers from the actual signal context. This change
    correctly captures these regions and stores them in the exception
    snapshot.
    
    Change-Id: I494e753a25c2687e61b5183ed0135f520ca8bf52
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5380505
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    1cea047 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Configuration menu
    Copy the full SHA
    de1f583 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Move crashpad to using Mac-13|Mac-14 (like chromium) and latest win sdk

    This should give crashpad a newer xcode and msvc that support C++20.
    
    These changes need to land separately from the C++20 usage, as they do
    not get applied until after landing, so can't affect the CQ from inside
    the CQ.
    
    Bug: 40284755
    Change-Id: I3ae72befa008bfb37bac882de0986c5bcf9de079
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5425460
    Commit-Queue: danakj <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    danakj authored and Crashpad LUCI CQ committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    bbb99bf View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Roll mini_chromium to pick up the latest version of base::span.

    Also enables C++20 as span now depends on it.
    
    Roll buildtools to grab a newer libc++ that supports C++20.
    
    Explicitly capture `this` in lambdas in cpp-httplib as the implicit
    capture through `=` is deprecated and causes an error in C++20.
    
    Update the MacOS version to "Mac-13|Mac-14" which is the current
    value of `os.MAC_DEFAULT` in Chromium infra in order to have
    C++20 support in the std library on iOS.
    
    Moves iOS tests to run on iPhone 13 and includes a mini_chromium roll
    to fix Xcode 14.3 egtests.
    
    Bug: 40284755
    Change-Id: Ic078f07d12473f2aaed5e84df0f0a7fb7b8c35c3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5443384
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: danakj <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    f9cee5c View commit details
    Browse the repository at this point in the history
  2. [ios] Fix TSAN issue and Mach port leak in CrashpadClient

    There were two issues with the iOS implementation of CrashpadClient
    which I reported in https://crbug.com/crashpad/481:
    
    1) TSAN found a data race in ResetForTesting() when it modified the
    ScopedMachReceiveRight while the Mach exception port thread was
    reading it
    
    2) The Mach port connected to the exception server was never deallocated
    
    This CL fixes both issues.
    
    Change-Id: I5bd4f79ae6d0eccca954d663be7a36f8ceb0a0e8
    Bug: https://crbug.com/crashpad/481
    Bug: b:332305593
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5410301
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Justin Cohen <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8df174c View commit details
    Browse the repository at this point in the history
  3. Use byte conversions over the byte swap functions

    base/sys_byteorder.h is going away. Instead, use the byte conversions
    in base::numerics to convert from a byte array in big endian to an
    integer. This avoids putting big endian data into integer types at all.
    
    mini_chromium was rolled and crashpad updated to work with newer
    mac/windows toolchains in order to support C++20 in
    f9cee5c.
    
    Bug: 40284755
    Change-Id: If690847b7aa54b0216e73ec297eae3d0bca2fa57
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5402184
    Commit-Queue: danakj <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    danakj authored and Crashpad LUCI CQ committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7e0af1d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Configuration menu
    Copy the full SHA
    96e301b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Replace std::unique_ptr<T[]> with HeapArray in process_info.cc and

    process_info_test.cc
    
    Bug: crashpad: 326459035,326458915,326459055
    Change-Id: Ifb91297b6097aa81a9d5c883b2c284e9fdd512a8
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5463361
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Arthur Wang <[email protected]>
    wuwang-wang authored and Crashpad LUCI CQ committed May 2, 2024
    Configuration menu
    Copy the full SHA
    76badd4 View commit details
    Browse the repository at this point in the history
  2. Fix incorrect DCHECK in CET contexts

    This DCHECK() was not correct. When dumping a process with CET
    enabled the cetumsr and cetussp registers are not available in
    the context obtained for the exception record. All contexts to be
    written to a minidump must have the same context format so those
    registers will be present for captured threads. It is therefore ok for
    the context to expect extended xsave registers but for them to be
    zero in some cases.
    
    Bug: 337665168
    Change-Id: If7e5f40fe8eda6799b034991cb87e89437cb4821
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5507588
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Alex Gough <[email protected]>
    quidity authored and Crashpad LUCI CQ committed May 2, 2024
    Configuration menu
    Copy the full SHA
    dc48905 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Replace std::is_pod usage

    Replacing std::is_pod usage as per the following compilation error:
    ```
    ../../util/misc/uuid.cc:44:20: error: 'is_pod<crashpad::UUID>' is deprecated: use 'is_standard_layout && is_trivial' instead [-Werror,-Wdeprecated-declarations]
    static_assert(std::is_pod<UUID>::value, "UUID must be POD");
                       ^
    /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/type_traits:818:5: note: 'is_pod<crashpad::UUID>' has been explicitly marked deprecated here
        _GLIBCXX20_DEPRECATED_SUGGEST("is_standard_layout && is_trivial")
    
    ```
    
    Bug: None
    Change-Id: I1d61ee12261877f7f1f84f0ea15d262d22959766
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5472885
    Commit-Queue: Andrew Williams <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    recvfrom authored and Crashpad LUCI CQ committed May 3, 2024
    Configuration menu
    Copy the full SHA
    da18935 View commit details
    Browse the repository at this point in the history
  2. Make NTSTATUS_LOG less likely to change ::GetLastError() value

    This better ensures that using code like
    `NTSTATUS_LOG(ERROR, status) << ::GetLastError()` would print the
    intended value. This isn't done today by the code AFAICT, but
    making this change primarily for consistency with the change to
    Chromium logging in
    https://chromium-review.googlesource.com/c/chromium/src/+/5443628
    
    Bug: chromium:333445539
    Change-Id: I49f16b9ed78d98a0b2f178f58465002aad757ae5
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5474027
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Andrew Williams <[email protected]>
    recvfrom authored and Crashpad LUCI CQ committed May 3, 2024
    Configuration menu
    Copy the full SHA
    bff9873 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Use the span version of RandBytes

    Some unique_ptr<T[]> are also changed to HeapArray in order to
    facilitate the change.
    
    Bug: chromuim: 40284755
    Change-Id: I30b9d55ff81f23c63ad4958786740f67ee612024
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5512569
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: danakj <[email protected]>
    danakj authored and Crashpad LUCI CQ committed May 6, 2024
    Configuration menu
    Copy the full SHA
    84c8773 View commit details
    Browse the repository at this point in the history
  2. Include build_config.h before checking COMPILER_MSVC

    This is caught by chromium presubmit when rolling crashpad.
    
    [email protected]
    
    Change-Id: Ida9ff07e7b2bd27808c092afbc5a1345fa29a4f3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5515300
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: danakj <[email protected]>
    danakj authored and Crashpad LUCI CQ committed May 6, 2024
    Configuration menu
    Copy the full SHA
    5c09c9a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Roll mini_chromium to remove the pointer-based overload of RandBytes()

    [email protected]
    
    Bug: 40284755
    Change-Id: I2f491cc3f630767e607ea1df7d21791be522b4de
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5518909
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: danakj <[email protected]>
    danakj authored and Crashpad LUCI CQ committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8e60a93 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. ios: Use correct address when storing register memory.

    The memory region data saved in the intermediate dump is an address
    offset by 128 bytes. However, the MemorySnapshot generated was using the
    original address and not the offset address.  The same data is being
    captured in the minidump.
    
    Change-Id: Ia34912c035319e79cf446a130e662084f4ab51ea
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5529059
    Commit-Queue: Justin Cohen <[email protected]>
    Reviewed-by: Joshua Peraza <[email protected]>
    Reviewed-by: Rohit Rao <[email protected]>
    Justin Cohen authored and Crashpad LUCI CQ committed May 9, 2024
    Configuration menu
    Copy the full SHA
    3710831 View commit details
    Browse the repository at this point in the history
  2. Replace std::unique_ptr<T> with HeapArray

    Bug: crashpad: 326459659,326458942,326459376,326459390,326459417,326458979,326459333,326459016,326458338,326458738,326459156,326459512,326458694
    Change-Id: I04724530cbef50a8d3c18f306d16c0bbf3b0815b
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5512394
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Arthur Wang <[email protected]>
    wuwang-wang authored and Crashpad LUCI CQ committed May 9, 2024
    Configuration menu
    Copy the full SHA
    981d418 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Pull latest Fuchsia toolchain

    Change-Id: Ia328c6defc59fc06fcf69a2875a0eed335c8dd78
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5532142
    Commit-Queue: Arthur Wang <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    wuwang-wang authored and Crashpad LUCI CQ committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9032284 View commit details
    Browse the repository at this point in the history
  2. Add build/build_config.h in capture_memory.cc

    Change-Id: I486e7bcdb205de5b24846a8e782a6163c2ce8829
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5531439
    Commit-Queue: Arthur Wang <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    wuwang-wang authored and Crashpad LUCI CQ committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1174aa4 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Replace std::unique_ptr with base::HeapArray in process_memory.cc

    Bug: crashpad:326459219
    Change-Id: Ic5e252285ed1fb1769eef67ddaea00a830d0ee6a
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5535006
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Arthur Wang <[email protected]>
    wuwang-wang authored and Crashpad LUCI CQ committed May 14, 2024
    Configuration menu
    Copy the full SHA
    4f99326 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Fix format issue

    Change-Id: I9756fa76f94cfcb9edc9f8df8ecfa5ff33918c22
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5542412
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Arthur Wang <[email protected]>
    wuwang-wang authored and Crashpad LUCI CQ committed May 15, 2024
    Configuration menu
    Copy the full SHA
    aef8303 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Add guard pages to test stacks

    Bug: b:340659332
    Change-Id: I4c2c82a1868d7a4f4a062a4e7a64258deedfb794
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5542248
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Joshua Peraza <[email protected]>
    Joshua Peraza authored and Crashpad LUCI CQ committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0e043cc View commit details
    Browse the repository at this point in the history
  2. [ScopedSpinGuard] Use std::atomic::compare_exchange_strong() for spin…

    …lock
    
    Previously, ScopedSpinGuard used std::atomic::compare_exchange_weak()
    in a loop to implement a spinlock. After looping for the specified
    number of nanoseconds, it would give up and return an error.
    
    A few bugs have come in on ARM platforms (https://crbug.com/340980960,
    http://b/296082201) which indicate that this can fail even in
    single-threaded cases where nothing else has the spinlock.
    
    From https://cbloomrants.blogspot.com/2011/07/07-14-11-compareexchangestrong-vs.html :
    
    > compare_exchange_weak exists for LL-SC (load linked/store
    > conditional) type architectures (Power, ARM, basically everything
    > except x86), because on them compare_exchange_strong must be
    > implemented as a loop, while compare_exchange_weak can be
    > non-looping.
    
    and:
    
    https://en.cppreference.com/w/cpp/atomic/atomic/compare_exchange#Notes
    
    > compare_exchange_weak is allowed to fail spuriously, that is, acts
    > as if *this != expected even if they are equal. When a
    > compare-and-exchange is in a loop, compare_exchange_weak will yield
    > better performance on some platforms.
    >
    > When compare_exchange_weak would require a loop and
    > compare_exchange_strong would not, compare_exchange_strong is
    > preferable [...]
    
    My conclusion is that this logic needs to use
    `compare_exchange_strong` to avoid spurious failures on ARM in the
    common case when there's no other thread holding the spinlock.
    
    Change-Id: I2a08031db6b219d7d14a5cd02b3634985f81ab06
    
    Bug: b:340980960
    Change-Id: I2a08031db6b219d7d14a5cd02b3634985f81ab06
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5545257
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Ben Hamilton <[email protected]>
    bhamiltoncx authored and Crashpad LUCI CQ committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d588c50 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Roll crashpad/third_party/mini_chromium/mini_chromium/ a6607b1fd..585…

    …6e1ea6 (2 commits)
    
    https://chromium.googlesource.com/chromium/mini_chromium/+log/a6607b1fd76b..5856e1ea610f
    
    $ git log a6607b1fd..5856e1ea6 --date=short --no-merges --format='%ad %ae %s'
    2024-05-16 pbos Add NOTREACHED_IN_MIGRATION()
    2024-05-11 pwjworks Remove workaround for missing std::atomic_thread_fence
    
    Created with:
      roll-dep crashpad/third_party/mini_chromium/mini_chromium
    
    Bug: chromium:40580068
    Change-Id: I6d1385739042fa5b826bfa91c50b914eebaaf8fd
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5544927
    Commit-Queue: Peter Boström <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    pbos authored and Crashpad LUCI CQ committed May 17, 2024
    Configuration menu
    Copy the full SHA
    efd29a7 View commit details
    Browse the repository at this point in the history
  2. Use NOTREACHED_IN_MIGRATION()

    This was generated by replacing "  NOTREACHED()" with
    "  NOTREACHED_IN_MIGRATION()" and running git cl format.
    
    This prepares for making NOTREACHED() [[noreturn]] alongside
    NotReachedIsFatal migration of existing inventory.
    
    Bug: chromium:40580068
    Change-Id: Idb68e2fc8adba180350b0595fd494cf0f206bded
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5548246
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Peter Boström <[email protected]>
    pbos authored and Crashpad LUCI CQ committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6af42bc View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. infra: Move crashpad ci/try builds from Ubuntu-18.04 to Ubuntu-22.04

    These are the last remaining jobs on the last remaining bionic pools.
    Moving these over should let the bionic flex pool finally be decommed.
    
    All of chrome/chromium has been on Ubuntu-22.04 for months now. So
    hopefully this is transparent for crashpad.
    
    Bug: chromium:40255350
    Change-Id: I82828c0ae0c6efc8868b33779d7ebf5fb9b16116
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5550958
    Commit-Queue: Ben Pastene <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    bpastene authored and Crashpad LUCI CQ committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cd0b7c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. ios: Remove duplicate implementations of ReadStringSysctlByName

    Bug: crashpad: 480
    Change-Id: Ie37c557d2170f6d96968ec4922ec52bfc6ad8136
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5580854
    Reviewed-by: Mark Mentovai <[email protected]>
    Justin Cohen committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0bebda6 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Updated codeowners (#102)

    Co-authored-by: jernejstrasner <[email protected]>
    jernejstrasner and jernejstrasner authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    08528d5 View commit details
    Browse the repository at this point in the history
  2. fix: crashpad build for Windows ARM64 via LLVM-MINGW (#101)

    * Add GAS version of capture_context_win_arm64.asm (for llvm-mingw)
    
    * Use capture_context_win_arm64.S on mingw targeting arm64
    
    * ci: tweak build matrix
    
    * ci: add llvm-mingw x64 build
    
    * ci: add llvm-mingw arm64 build
    
    * compat/mingw/werapi.h: Fix compat with recent mingw headers
    
    * ci: Bump actions/checkout to v4
    
    To fix "Node.js 16 actions are deprecated"
    past-due authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    202c1c2 View commit details
    Browse the repository at this point in the history
  3. [Fuchsia] Run fuchsia-gn-sdk from chromium

    The latest build rules have the ffuchsia-api-level.
    Need https://crrev.com/c/5586319.
    
    Bug: fuchsia:42085580, fuchsia:327691011
    Change-Id: I21383e02f9fff3db9405c0dbe42051122a325003
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5585353
    Commit-Queue: Zijie He <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    zijiehe-google-com authored and Crashpad LUCI CQ committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    25c079d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. DEPS: fix version of fuchsia/sdk/core to avoid build error

    This is a temporary workaround to avoid error like
    https://ci.chromium.org/ui/p/crashpad/builders/try/crashpad_fuchsia_arm64_dbg/1299/overview
    
    Bug:  41489832
    Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5599904
    Commit-Queue: Takuto Ikuta <[email protected]>
    Reviewed-by: Mark Mentovai <[email protected]>
    Takuto Ikuta authored and Crashpad LUCI CQ committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a63adda View commit details
    Browse the repository at this point in the history
  2. remove references to goma

    goma is not maintained anymore.
    
    Bug: 41489832
    Change-Id: Ic82524205c7593ddba041c253e7d6283f9c89f33
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5599864
    Reviewed-by: Mark Mentovai <[email protected]>
    Commit-Queue: Takuto Ikuta <[email protected]>
    Takuto Ikuta authored and Crashpad LUCI CQ committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c09de98 View commit details
    Browse the repository at this point in the history
  3. Revert "DEPS: fix version of fuchsia/sdk/core to avoid build error"

    This reverts commit a63adda.
    
    Reason for revert:
    This is not necessary after https://crrev.com/c/5585353.
    
    Original change's description:
    > DEPS: fix version of fuchsia/sdk/core to avoid build error
    >
    > This is a temporary workaround to avoid error like
    > https://ci.chromium.org/ui/p/crashpad/builders/try/crashpad_fuchsia_arm64_dbg/1299/overview
    >
    > Bug:  41489832
    > Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
    > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5599904
    > Commit-Queue: Takuto Ikuta <[email protected]>
    > Reviewed-by: Mark Mentovai <[email protected]>
    
    Bug: 41489832
    Change-Id: I2c6d3c3008047a6f79fb3bfddd8240a758ee645a
    Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5599914
    Reviewed-by: Mark Mentovai <[email protected]>
    Bot-Commit: Rubber Stamper <[email protected]>
    Commit-Queue: Takuto Ikuta <[email protected]>
    Takuto Ikuta authored and Crashpad LUCI CQ committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a1fc5d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Configuration menu
    Copy the full SHA
    7e36850 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dbe6f74 View commit details
    Browse the repository at this point in the history
  3. Update minichromium

    supervacuus committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d430e3f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a52e010 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ff8eed7 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    4751fa2 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Merge pull request #106 from getsentry/fix/further_cmake_deps_cleanup

    fix: further dependency use/export cleanup
    supervacuus authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    11b9eaf View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Configuration menu
    Copy the full SHA
    84f5f87 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Configuration menu
    Copy the full SHA
    04101eb View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    8961424 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b95f5c6 View commit details
    Browse the repository at this point in the history