This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Remove reliance on pkg/errors #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually use anything out of this library except talking with it's interfaces, so let's abstract out usage rather than forcing a strong dependency on the library.
dcramer
reviewed
Jan 8, 2019
| } | ||
| return &Stacktrace{Frames: frames} | ||
| } else { | ||
| type stackTracer interface { |
There was a problem hiding this comment.
this is when i remember i dont know go well enough to understand what this is for
dcramer
approved these changes
Jan 8, 2019
| return &Stacktrace{Frames: frames} | ||
| } else { | ||
| type stackTracer interface { | ||
| StackTrace() []runtime.Frame |
There was a problem hiding this comment.
In respect of /pkg/errors this implementation does not work. Not yet sure if I'm doing something wrong, but passing error created by errors.New(...) to this function, ends up in !ok if statement. This is because pkg/errors says:
// New, Errorf, Wrap, and Wrapf record a stack trace at the point they are
// invoked. This information can be retrieved with the following interface:
//
// type stackTracer interface {
// StackTrace() errors.StackTrace
// }
//
// The returned errors.StackTrace type is defined as
//
// type StackTrace []Frame
How should I use this method with /pkg/errors ? Im confused.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually use anything out of this library except talking with
it's interfaces, so let's abstract out usage rather than forcing a
strong dependency on the library.