-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(replays): Use all bytes after the first newline split as the body value #1682
Conversation
fede23f
to
5593280
Compare
a738286
to
50481e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left few suggestions.
My questions is just why don't use the bytes slice directly and avoid wrapping it in the cursor and introducing another Vec
, where we again just copying data.
I've tested the proposed changes locally and looks like all the tests are still passing.
Please, have a look and let me know what you think.
@olksdr The answer to these questions and more is that I do not know rust :D. Strict code reviews are appreciated and encouraged. |
closes: https://github.com/getsentry/replay-backend/issues/227
#skip-changelog