Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(replays): Use all bytes after the first newline split as the body value #1682

Merged
merged 9 commits into from
Dec 9, 2022

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Dec 7, 2022

@cmanallen cmanallen requested a review from a team December 7, 2022 17:38
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few suggestions.
My questions is just why don't use the bytes slice directly and avoid wrapping it in the cursor and introducing another Vec, where we again just copying data.

I've tested the proposed changes locally and looks like all the tests are still passing.

Please, have a look and let me know what you think.

CHANGELOG.md Outdated Show resolved Hide resolved
relay-replays/src/recording.rs Outdated Show resolved Hide resolved
relay-replays/src/recording.rs Outdated Show resolved Hide resolved
@cmanallen
Copy link
Member Author

cmanallen commented Dec 9, 2022

My questions is just why don't use the bytes slice directly and avoid wrapping it in the cursor and introducing another Vec, where we again just copying data.

@olksdr The answer to these questions and more is that I do not know rust :D. Strict code reviews are appreciated and encouraged.

@cmanallen cmanallen enabled auto-merge (squash) December 9, 2022 13:16
@cmanallen cmanallen merged commit e10a251 into master Dec 9, 2022
@cmanallen cmanallen deleted the replays-fix-decompression branch December 9, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants