-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replays): Add killswitch for mobile replays #3402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, some test coverage would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving not to block on the option name, but please align the PR description with the code before merging.
Organizations are not allowed unless the
organizations:session-replay-video
flag evaluates totrue
.Related: getsentry/sentry#63255
Related PRs:
https://github.com/getsentry/getsentry/pull/13596/files
https://github.com/getsentry/sentry/pull/68567/files