Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): Add features to client sdks #3478

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Apr 24, 2024

This PR adds features to the ClientSDKInfo. Related develop docs PR: getsentry/develop#1244 and team SDK GH issue: getsentry/team-sdks#83.

This PR adds features to the ClientSDKInfo. Related develop docs PR:
getsentry/develop#1244.
@philipphofmann philipphofmann requested a review from a team as a code owner April 24, 2024 09:11
@philipphofmann
Copy link
Member Author

philipphofmann commented Apr 24, 2024

Install libcurl-dev is failing for all CI jobs. Can someone please help me to fix this?

It seems like something is wrong with the signing of these packages.

E: Failed to fetch https://packages.microsoft.com/ubuntu/22.04/prod/dists/jammy/InRelease  Clearsigned file isn't valid, got 'NOSPLIT' (does the network require authentication?)
E: The repository 'https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease' is no longer signed.

Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A list can only track enabled features, would we be interested in tracking some other initialization values for future compatibility? For example, one can't tell the difference between a sample_rate=0.7 vs sample_rate=1 with just a list. This is solved with an object, in which we forward unknown attributes and thus leave the door open for future extension.

(sorry for getting a bit late here)

@philipphofmann
Copy link
Member Author

A list can only track enabled features, would we be interested in tracking some other initialization values for future compatibility? For example, one can't tell the difference between a sample_rate=0.7 vs sample_rate=1 with just a list. This is solved with an object, in which we forward unknown attributes and thus leave the door open for future extension.

The purpose is only to track enabled features. If we want to track something like sample_rate=0.7 vs sample_rate=1, I think we should add another object. This sounds more like SDK config or something. We also plan on indexing this data in Looker, so a list with only strings has a lower cardinality.

@iker-barriocanal
Copy link
Contributor

Sgtm then 👍

For CI failures, rerunning jobs should be good enough. Seems like something was off in GitHub jobs

@philipphofmann philipphofmann merged commit 52f9bb0 into master Apr 25, 2024
20 checks passed
@philipphofmann philipphofmann deleted the feat/sdk-features branch April 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants