-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move unbound_send outside of the function #648
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 2872 2874 +2
=========================================
+ Hits 2872 2874 +2
☔ View full report in Codecov by Sentry. |
Is there a use case for overwriting this method and behavior? |
@markstory while working on the bug for a bit hard to explain. |
but generally, it will not hard. Since this produces a cleaner way to handle methods within class and provides more granular control |
Moving
unbound_on_send
outside of the function will allow users to override the method if they will need to without a need to rewrite the entirestart
method