-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc(feature): Exception Groups #79
Conversation
3db878c
to
c07b462
Compare
Co-authored-by: Abhijeet Prasad <[email protected]>
Yet another major rewrite of this RFC. I believe the plan is solid now 🤞 😅 Please read the revised proposal, starting from the "Proposed Solution" section. (Everything prior is as before.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new approach looks good to me, and makes sense on the SDK side. Thanks for keeping this going @mattjohnsonpint!
An a posteriori learning: Extending an interface, which in itself is optional but has required fields (i.e. Maybe we should have put all the extra data onto the exception interface directly 🤔 |
Design for changes required to support exception groups.
Rendered RFC