Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Export typings/types #60

Merged
merged 1 commit into from
Feb 23, 2023
Merged

feat(types): Export typings/types #60

merged 1 commit into from
Feb 23, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 22, 2023 •
edited
Loading

Let's export all of these types so we can use them.

@billyvg billyvg marked this pull request as ready for review February 22, 2023 22:47
@billyvg billyvg requested review from mydea and Lms24 February 22, 2023 22:47
@billyvg billyvg mentioned this pull request Feb 22, 2023
Merged
Lms24
Lms24 approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since we don't make semver guarantees for this pacakge, we don't need to worry about API surface anyway.

@billyvg billyvg merged commit 557c3af into sentry-v1 Feb 23, 2023
@billyvg billyvg deleted the feat-types-export-typings-types branch February 23, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyvg @Lms24